Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra action Links being added/styled in Rich text editors #16107

Open
1 of 7 tasks
laflannery opened this issue Nov 13, 2023 · 4 comments
Open
1 of 7 tasks

Extra action Links being added/styled in Rich text editors #16107

laflannery opened this issue Nov 13, 2023 · 4 comments
Labels
CMS Team CMS Product team that manages both editor exp and devops Defect Something isn't working (issue type) Drupal engineering CMS team practice area

Comments

@laflannery
Copy link
Contributor

Describe the defect

When I add an action link style within a Rich text editor, it looks like an additional link is being added to the end (or next line if I hit enter). These "additional" links aren't saving and they don't appear if I go back into the content later but it's very confusing for the content editor because I can't find a way to get rid of it. I am also not able to get out of the link style formatting.

image

image

image

To Reproduce

Steps to reproduce the behavior:

  1. Go to a rich text editor
  2. Create an action link, either Primary or Secondary
  3. Notice that 2 icons appear, one before the link (where it should) and one after the link (which is incorrect)
  4. Try to delete the second icon without using the source code.
  5. Notice that you cannot
  6. Try to type in standard text formatting
  7. Notice that you also cannot do this but instead it remains formatted as link text

AC / Expected behavior

  • Link formatting should only apply to the originally created/highlighted text
  • No additional icons or action links should be created

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • User support
  • Accelerated Publishing
@laflannery laflannery added Defect Something isn't working (issue type) Needs refining Issue status labels Nov 13, 2023
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Nov 13, 2023
@edmund-dunn edmund-dunn added Drupal engineering CMS team practice area and removed Needs refining Issue status labels Nov 15, 2023
@edmund-dunn
Copy link
Contributor

This is an upstream issue with ckeditor5. Drupal issue here https://www.drupal.org/project/drupal/issues/3376167 I am patching it which improves the functionality but doesn't entirely fix it. We will need to watch it for the permanent fix/patch.

@edmund-dunn
Copy link
Contributor

@BerniXiongA6 this is blocked until the upstream issue is fixed.

@laflannery
Copy link
Contributor Author

Talked to @EWashb and I'm going to update the KB article regarding the Text editor to have a section regarding this weirdness to warn editors and assist the Helpdesk with supporting the editors.

@laflannery
Copy link
Contributor Author

Update article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Defect Something isn't working (issue type) Drupal engineering CMS team practice area
Projects
None yet
Development

No branches or pull requests

2 participants