Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for alt text validation #15783

Closed
1 of 7 tasks
edmund-dunn opened this issue Oct 23, 2023 · 11 comments · Fixed by #15787
Closed
1 of 7 tasks

Create tests for alt text validation #15783

edmund-dunn opened this issue Oct 23, 2023 · 11 comments · Fixed by #15787
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area

Comments

@edmund-dunn
Copy link
Contributor

User Story or Problem Statement

Create tests that test hard and client-side validations for the alt text field. Test should test the alt text functionality in the /media/add/image page and test all three new validations.

  • Alt text input field is over 150 characters.
  • Alt text includes any of the following file extensions: .png .gif .jpg .jpeg
  • Alt text contains any of the following phrases “image of”, “photo of”, “graphic of”, or “picture of”.

Acceptance Criteria

  • Test character limit, client-side, and hard validations.
  • Test no file names, client-side, and hard validations.
  • Test no redundant phrases, client-side, and hard validations.

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@edmund-dunn edmund-dunn added Drupal engineering CMS team practice area Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops labels Oct 23, 2023
@edmund-dunn edmund-dunn self-assigned this Oct 23, 2023
@BerniXiongA6
Copy link

Hey @edmund-dunn @tonytaylor -- will tee this one up for us to discuss at backlog refinement -- thanks! cc: @ndouglas @EWashb

@ndouglas
Copy link
Contributor

ndouglas commented Nov 1, 2023

Hey team! Please add your planning poker estimate with Zenhub @edmund-dunn @JunTaoLuo @tonytaylor

@BerniXiongA6
Copy link

@tonytaylor -- we can chat about this ticket at Sprint Planning -- thanks! cc: @edmund-dunn

@tonytaylor
Copy link
Contributor

We're in good shape with some lovely tests. Will be working with @JunTaoLuo tomorrow to clean up some commits. Closed by EOD 11/22.

@BerniXiongA6
Copy link

Thanks @tonytaylor and @JunTaoLuo !

@BerniXiongA6
Copy link

Since we've reopened to only have the PR reviewed by UX and a11y, and merged when approved -- I'm going to consider this as 2 points for Sprint 98. cc: @maortiz-27-80

@BerniXiongA6
Copy link

Will this get reviewed adn closed soon? Please advise @tonytaylor @laflannery @BlakeOrgan -- cc: @maortiz-27-80

@laflannery
Copy link
Contributor

@BerniXiongA6 Blake and I both already reviewed - our comments are on the PR:

So I think the only thing left to do would be to update the link Blake pointed out

@BerniXiongA6
Copy link

Thanks @laflannery @BlakeOrgan -- hey @tonytaylor would you know when you could get this final change completed ? cc: @maortiz-27-80

@tonytaylor
Copy link
Contributor

@BerniXiongA6 this will be wrapped up a bit later this morning.

@BerniXiongA6
Copy link

@edmund-dunn do we know if this one got reviewed/QA'ed? Could you help @maortiz-27-80 and me to decipher whether we could close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants