Skip to content

Commit

Permalink
Merge branch 'main' into integration-form-engine-2
Browse files Browse the repository at this point in the history
  • Loading branch information
derekhouck authored Dec 10, 2024
2 parents f7761fd + 0df45e1 commit 25e9c36
Show file tree
Hide file tree
Showing 252 changed files with 8,615 additions and 2,614 deletions.
2 changes: 1 addition & 1 deletion .ddev/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ web_environment:
- CMS_MARIADB_USERNAME=db
- CMS_MARIADB_PASSWORD=db
- CMS_MARIADB_HOST=db
- CYPRESS_TAGS=\"not @ignore and not @piv\"
- CYPRESS_TAGS=\"not @piv\"
- DDEV_APPROOT=/var/www/html
- DRUPAL_ADDRESS=https://va-gov-cms.ddev.site
nodejs_version: "16"
Expand Down
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
/config/sync/*full_width_banner_alert* @department-of-veterans-affairs/facilities-cms
# To catch VAMC stuff with older naming convention
/config/sync/*health_care* @department-of-veterans-affairs/facilities-cms
/config/sync/*connect_with_us* @department-of-veterans-affairs/public-websites-cms
/config/sync/*jsonapi* @department-of-veterans-affairs/accelerated-publishing
# aka VAMC System Locations List
/config/sync/*locations_listing* @department-of-veterans-affairs/facilities-cms
Expand Down
42 changes: 42 additions & 0 deletions .github/ISSUE_TEMPLATE/ap-migration.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
---
name: "(AP) Next-build migration"
about: Templates to be migrated to next-build
title: "Next Build Template: "
labels: Accelerated Publishing, Migration
assignees: ''

---

## Template or Content Type
_Name of template or content type_

## Example
_URL to show an example of the template or content type in both Drupal CMS and VA.gov_

## Description
_Overview of template or content type, including relevant details to the migration lift._

## Product Owner
_The team that owns the product in production_

## Definition of Done
**Data:**
- [ ] Conditional logic matches content-build / production
- [ ] SEO Metadata matches production
- [ ] Analytics match production

**Interaction / Behavior:**
- [ ] Interactions / behavior match production (e.g. accordion expansion by default on page load if they do, data IDs on elements / their usage, link behavior, form / input field behaviors, etc)

**Accessibility:**
- [ ] Accessibility experience matches production (voiceover/screen reader behavior, appearance at 400% zoom, params on elements, etc)
- [ ] axe devTools output matches production

**Visual presentation:**
- [ ] Design system components, prop usage and component versions match production
- [ ] Design (font size, spacing, Anything else?) matches production
- [ ] Review all breakpoints

**Signoff / Launch**
- [ ] Owning team has reviewed the build and provided feedback / approval
- [ ] CMS Team has confirmed launch readiness
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE/draft-content-published-to-va-gov.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
name: Draft Content Published to VA.gov
about: Document any content that was publisehd to Va.gov when it was still in the draft state
title: Draft Drupal content published to VA.gov from [page in CMS]
labels: CMS Team, sitewide, Defect, Needs refining
assignees: ''

---

## VA.gov URL where draft content appeared
- Va.gov link:

## Drupal origin of the draft content that appeared on prod
- Drupal link:

If you're not sure, note that.

## Changes that were in draft that shouldn't have been published
- Drupal revision link:
Please describe the changes

### Was the content previously published, or has always been draft?
- [ ] Previously published
- [ ] Has always been draft

## Screenshots
{Any screenshots of the content. Feel free to remove this section if there aren't any.}
16 changes: 8 additions & 8 deletions .github/ISSUE_TEMPLATE/runbook---ux-research.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ assignees: ''
**How to set up a new UX research epic**
- [ ] Create a Research [Epic](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?assignees=&labels=Epic%2C+Needs+refining&template=cms-epic.md&title=%3CInsert+summary+of+epic%3E) for your product/initiative
- [ ] Create a Research Folder following [Platform's Research guidance](https://depo-platform-documentation.scrollhelp.site/research-design/research-checklist#ResearchChecklist-1.Planningforresearch)
- [ ] Create a [Research Discovery](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-discovery.md) issue
- [ ] Create a [Research Plan](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-plan.md) issue
- [ ] Create a [Research Conversation Guide](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-conversation-guide.md) issue
- [ ] Create a [Research Collab Cycle](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-collab-cycle.md) issue
- [ ] Create a [Research Prep](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-prep.md) issue
- [ ] Create a [Research Sessions](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-sessions.md) issue
- [ ] Create a [Research Synthesis and Reporting](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-synthesis-and-reporting.md) issue
- [ ] Create a [Research Readout and Post-tasks](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-readout-and-post-tasks.md) issue
- [ ] Create a [Research Discovery](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-discovery.md) issue
- [ ] Create a [Research Plan](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-plan.md) issue
- [ ] Create a [Research Conversation Guide](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-conversation-guide.md) issue
- [ ] Create a [Research Collab Cycle](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-collab-cycle.md) issue
- [ ] Create a [Research Prep](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-prep.md) issue
- [ ] Create a [Research Sessions](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-sessions.md) issue
- [ ] Create a [Research Synthesis and Reporting](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-synthesis-and-reporting.md) issue
- [ ] Create a [Research Readout and Post-tasks](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-readout-and-post-tasks.md) issue
- [ ] Add all the above issues to the Research Epic and add dependencies

## Acceptance Criteria
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-facility-url-change.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - Facility URL Change
about: Submit a request to change the URL of a facility
title: 'URL Change for: <insert facility name>'
labels: Drupal engineering, Facilities, Flagged Facilities, Redirect request, User
support
support, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-nca-facility-closed.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - NCA Facility closed
about: Steps for archiving a NCA facility in VA.gov CMS.
title: 'NCA Facility closed: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, NCA, User
support
support, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-nca-facility-name-change.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - NCA Facility name change
about: Steps for updating names and URLs
title: 'NCA Facility name change: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, NCA, User
support
support, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-nca-facility-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - New NCA Facility
about: changing facility information in the CMS for NCA facilities
title: 'New NCA Facility: <insert_name_of_facility>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VBA
VBA, sitewide
assignees: ''

---
Expand Down
20 changes: 11 additions & 9 deletions .github/ISSUE_TEMPLATE/runbook-new-vamc-system.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ assignees: ''
### Menu configuration and clean up [CMS helpdesk or Sitewide team]
- [ ] Go to [Content / Menus](https://prod.cms.va.gov/admin/structure/menu)
- [ ] Find the relevant menu and select edit menu
- [ ] Ensure all menu links are nested in the proper place
- [ ] Set some menu links to disabled
- [ ] Consult [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) for menu settings (Here's a [backup static copy](https://github.com/department-of-veterans-affairs/va.gov-team/blob/1b010e72b992dbefa7305764b0058841131733bc/products/facilities/medical-centers/VAMC-Sitemap.xlsx) in case of access issues in the future)
- [ ] Ensure all menu links are nested in the proper place by opening each menu item individually and ensuring it has the correct parent link, and saving
- [ ] Set some menu links to disabled, according to the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh)
- [ ] Consult [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) for menu settings (Here's a [backup static copy](https://github.com/department-of-veterans-affairs/va.gov-team/blob/1b010e72b992dbefa7305764b0058841131733bc/products/facilities/medical-centers/VAMC-Sitemap.xlsx) in case of access issues in the future)

### URL alias configuration [CMS helpdesk or Sitewide team]
- [ ] Check that each page has the correct URL alias matching the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh)
- [ ] Check that each page has the correct URL alias matching the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh), and breadcrumb
- [ ] If pages dont have the correct URL Alias, change them from Auto to Manual and input the correct URL alias

### User set up [CMS helpdesk]
Expand All @@ -132,9 +132,11 @@ assignees: ''
### VAMC editor tasks
- [ ] Complete training if they haven't already
- [ ] Follow the instructions in [VAMC editor guide](https://prod.cms.va.gov/help/vamc)
- [ ] Confirm when ready to publish
- [ ] Advise the Editor not to publish content until all drafts, including Top Task pages, are ready to Publish.
- [ ] Ask the Editor to confirm when they are ready for Helpdesk / Sitewide to publish the site

### Launch tasks
- [ ] Lighthouse coordination for service push?
- [ ] Redirects?
- [ ] Comms, change management?
### Launch tasks [CMS helpdesk or Sitewide team]
- [ ] Bulk publish content in a Tugboat and re-verify URLs, menu items / parents / structure, and breadcrumbs
- [ ] Coordinate timing with Editor for a bulk publish of all ready content in production, including Top Task pages
- [ ] If there is a legacy site for the system, or if existing facilities move into the new system, create a ticket for the appropriate redirects
- [ ] Notify the Editor that the site is published
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-vamc-facility-closed.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - VAMC Facility closed
about: Steps for archiving a VAMC facility in VA.gov CMS.
title: 'VAMC Facility closed: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VAMC
VAMC, sitewide
assignees: ''

---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - VAMC facility duplicate record or section change
about: How to update the section of a VAMC.
title: 'VAMC Facility duplicate record or section change: <insert_name_of_vamc>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VAMC
VAMC, sitewide
assignees: ''

---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - VAMC Facility name change
about: Steps for updating names and URLs
title: 'VAMC Facility name change: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VAMC
VAMC, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-vamc-facility-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - New VAMC Facility
about: changing facility information in the CMS for VAMC facilities
title: 'New VAMC Facility: <insert_name_of_facility>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VAMC
VAMC, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-vamc-system-name-change.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - VAMC system name change
about: How to update the name of a VAMC.
title: 'VAMC system name change: <insert_name_of_vamc>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VAMC
VAMC, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-vba-facility-closed.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - VBA Facility closed
about: Steps for archiving a VBA facility in VA.gov CMS.
title: 'VBA Facility closed: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VBA
VBA, sitewide
assignees: ''

---
Expand Down
10 changes: 5 additions & 5 deletions .github/ISSUE_TEMPLATE/runbook-vba-facility-launch.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ Facility CMS link: <insert_facility_link>

### Publishing
- [ ] Set the VBA Facility to Published, and note approvals in the revision log
- [ ] Create a [URL change ticket](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?assignees=&labels=Facilities%2C+Drupal+engineering%2C+Flagged+Facilities%2C+Redirect+request%2C+URL+Change%2C+User+support&projects=&template=runbook-facility-url-change.md&title=URL+Change+for%3A+%3Cinsert+facility+name%3E) for the URL update from facility locator detail page URL (using API ID) to the modernized URL. If you're unsure about the original URL, request help from Facilities team in #facilities-support.
- [ ] Ask Michelle Middaugh to update the facility URL in Sandy's Database to the modernized URL. This eliminates the need for a URL change request ([LH confirmed](https://dsva.slack.com/archives/C02BTJTDFTN/p1730395863667449?thread_ts=1730395217.135779&cid=C02BTJTDFTN)).
- [ ] Create a [redirect request](https://github.com/department-of-veterans-affairs/va.gov-team/issues/new?assignees=kristinoletmuskat%2C+strelich%2C+Agile6MSkinner&labels=sitewide+CAIA%2C+Sitewide+IA%2C+Facilities%2C+Regional+Office%2C+sitewide%2C+VA.gov+frontend%2C+Redirect+request&projects=&template=redirect-request.md&title=Redirect+Request) to redirect the previous TeamSite page to the modernized page.
- [ ] **Indicate in ticket** that this is a [page level redirect for a Teamsite using the injected header](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/engineering/redirect-implementation-strategy.md#3-subdomain--vagov-page-level-cross-domain-redirect-for-a-subdomain-that-loads-proxy-rewrite-js) -- it can be done within proxy rewrite as a client-side redirect

## Facilities engineer tasks
- [ ] After Content release has run and completed successfully, send a request to Lighthouse in #cms-lighthouse, to update the canonical URL from the API ID facility locator detail page, to the published / modernized page. **This may take several days for LH to complete.**
- [ ] Create a redirect in vsp-platform-revproxy to point traffic from the facility locator detail page to the modernized page path
- [ ] Notify VBA leadership, with CMS Helpdesk in cc, of completed launch, including: link to live Regional Office page(s), [VBA KB landing page](https://prod.cms.va.gov/help/veterans-benefits-administration-vba), and estimated timing from LH for the CSV updates
## Facilities PM / DM tasks
- [ ] Verify that TeamSite redirect is complete
- [ ] Verify that Facility Locator / LIghthouse redirect is complete
- [ ] Notify VBA leadership, with CMS Helpdesk in cc, of completed launch, including: link to live Regional Office page(s), [VBA KB landing page](https://prod.cms.va.gov/help/veterans-benefits-administration-vba)
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-vba-facility-name-change.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - VBA Facility name change
about: Steps for updating names and URLs
title: 'VBA Facility name change: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VBA
VBA, sitewide
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/runbook-vba-facility-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - New VBA Facility
about: changing facility information in the CMS for VBA facilities
title: 'New VBA Facility: <insert_name_of_facility>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
VBA
VBA, sitewide
assignees: ''

---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - Vet Center CAP becomes an Outstation
about: Steps for upgrading a CAP to an Outstation
title: 'Vet Center CAP becomes an Outstation: <insert_name_of_facility>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
Vet Center
Vet Center, sitewide
assignees: ''

---
Expand Down
18 changes: 10 additions & 8 deletions .github/ISSUE_TEMPLATE/runbook-vet-center-closed.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Runbook - Vet Center, Outstation, Mobile Vet Center Facility closed
about: Steps for archiving a Vet Center facility in VA.gov CMS.
title: 'Vet Center Facility closed: <insert_name>'
labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
Vet Center
Vet Center, sitewide
assignees: ''

---
Expand All @@ -20,7 +20,7 @@ Submitter: <insert_name>

- [ ] Contact the Vet Center editor and send them a link to the operating status KB article. If the facility has not closed yet and we can provide lead-time, the editor should change the Facility status to "Facility notice" and provide information in the Facility Status additional information about when the facility will permanently close.
- [ ] When the facility has already closed - including if we were unable to give the aforementioned lead time- the editor should change the Facility status to Closed and provide information in the Facility Status additional information that the facility has permanently closed as of DATE.
- Vet Center Mobile autoarchive when they are removed from the facilty API. No action required.
- Vet Center Mobiles autoarchive when they are removed from the facilty API. No action required.
- Vet Center Outstations autoarchive when they are removed from the facilty API. No action required.
- [ ] After 30 days of the facility being closed AND that the facility has been removed from the Lighthouse Facilities API, we can then archive the facility.
KB articles: <insert_kb_article_links>
Expand All @@ -29,20 +29,22 @@ KB articles: <insert_kb_article_links>
Facility CMS link: <insert_facility_link>
Facility API ID: <insert_facility_API_ID>

## Acceptance criteria
### Vet Center
Talk to Michelle

### Vet Center -> Talk to Michelle
### Mobile Vet Center closure
Autoarchive since they have no FE page of their own.

### Mobile Vet Center closure -> Autoarchive since they have no FE page of their own.

### Outstation -> Autoarchive since they have no FE page of their own.
### Outstation
Autoarchive since they have no FE page of their own.



#### CMS help desk steps
**Note: If the help desk is waiting on information from the facility staff or editor, add the "Awaiting editor" flag to the facility with a log message that includes a link to this ticket. Remove the flag when the ticket is ready to be worked by the Facilities team. Be sure to preserve the current moderation state of the node when adding or removing the flag.**
- [ ] 1. Become aware that the facility is no longer on the Facility API (typically, via a Flag, but this may come in as a helpdesk ticket).
- [ ] 2. ~~Create a [URL change](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?assignees=&template=runbook-facility-url-change.md&title=URL+Change+for%3A+%3Cinsert+facility+name%3E) to redirect the from the URL of the facility to be closed to the URL of its parent system and to remove the old canonical link.~~ redirects are not necessary for Outstations.
- [ ] 2. Create a [URL change](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?assignees=&template=runbook-facility-url-change.md&title=URL+Change+for%3A+%3Cinsert+facility+name%3E) to redirect the from the URL of the facility to be closed to the URL of its parent system and to remove the old canonical link.
* This step only applies to Vet Centers, and to Oustations that move to a new section. Outstations and Mobile VCs do not have pages of their own, but an Oustation _may_ have an entry in the Lighthouse CSV.

#### Drupal Admin steps (CMS Engineer or Help desk)
_Help desk will complete these steps or escalate to request help from CMS engineering._
Expand Down
Loading

0 comments on commit 25e9c36

Please sign in to comment.