DM 3631: Support /communities URL for Community pages #551

camillevilla · 2022-10-14T21:52:11Z

JIRA issue link

DM-3631

Description - what does this code do?

updates the webdrivers gem to fix an issue affecting local dev for M1 Macs (Webdrivers::NetworkError, probably due to new chromedriver naming titusfortner/webdrivers#237)
Adds support for /communities/:page_group/:page_slug/ in the
Removes unused subpage breadcrumb code that was creating an extra breadcrumb for this use case
adds a COMMUNITIES constant to navigation helper that includes xr-network
Edit breadcrumbs so that a community subpage always routes back to community homepage (e.g. /communities/xr-network/events has a breadcrumb back to /communities/xr-network)
Adds a redirect for /communities

Testing done - how did you test it/steps on how can another person can test it

Go to /admin/page_groups and create two page groups: xr-network and other
Go to /admin/pages and create two subpages: /xr-network/test and /other/test
Go to each page. Neither page should have breadcrumbs.
Go to /communities/xr-network/test. The content should be the same as /xr-network/test.
Go to admin/pages and create two home pages: /xr-network/home and /other/home.
Go to /communities/xr-network/test. The breadcrumb should link to `/communities/xr-network.
Go to /other/test. The breadcrumb should link to /other.
Edit /xr-network/test. Add an image component. Add a downloadable file component. Add a practice card list component.
Go to /xr-network/test and click on all page component links to make sure they still work as expected.
Go to /communities. The page should redirect to /communities/xr-network.

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

Determine how URLs are used for other pages
Determine how many things we can go deep
Can we do “communities/xr-network/PageName”
QA URLs
QA images
QA jumplinks

Make sure this doesn't break other pages

Definition of done

Unit tests written (if applicable)
e2e/accessibility tests written (if applicable)
Events are logged appropriately
Documentation has been updated, if applicable
A link has been provided to the originating JIRA issue
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

bradjohnson92008

Everything worked for me. Great job on this Camille.

JoshingYou1

Nice work on this Camille! I left a few comments. I'm also wondering if we should add a redirect in the controller, so if the user tries to visit xr-network/events, they get automatically routed to /communities/xr-network/events. With this suggestion, we may want to add a constant to the PageGroup class, kind of like how we did PRACTICE_EDITOR_SLUGS, and just call it COMMUNITY_SLUGS or something. That way we could just call it whenever we need to.

JoshingYou1 · 2022-10-17T21:14:55Z

app/helpers/navigation_helper.rb

-        def add_sub_page_breadcrumb
-          session[:breadcrumbs] << { 'display': "#{@page.title}", 'path': @builder_page_path }
-        end
-


I think we should keep this code. It was there for instances when the user navigated from a subpage to another page. For example, If the subpage had practices, when they clicked on the card and landed on the practice's show page, they would have a breadcrumb for both the landing page and the subpage

Sure, I've updated the branch so it retains that method.

JoshingYou1 · 2022-10-17T21:17:27Z

app/helpers/navigation_helper.rb

        elsif @builder_landing_page.exists?
          empty_breadcrumbs
          add_landing_page_breadcrumb("/#{params[:page_group_friendly_id]}")
-          add_sub_page_breadcrumb


Adding to the comment above, we could probably add some code like

is_communities_page = COMMUNITIES.include?(@page.page_group.slug)

somewhere above the if/else, and then do:

add_sub_page_breadcrumb unless COMMUNITIES.include?(@page.page_group.slug)

JoshingYou1 · 2022-10-17T21:19:42Z

config/routes.rb

+  # Accept pages with /communities prefix, e.g. /communities/xr-network/news
+  get '/communities/:page_group_friendly_id' => "page#show"
+  get '/communities/:page_group_friendly_id/:page_slug' => 'page#show'
+  get '/communities', to: redirect('/communities/xr-network') # temporary redirect until more communities are added


I think this is a good work-around! I'm wondering if we should think of a way to make the double-nested routes dynamic for future cases, so we don't have to continually add new routes.

@JoshingYou1 do you mean Line 133? This route should get removed once we have a second community (and ideally have a Communities home page).

camillevilla · 2022-10-17T23:18:49Z

Ok, so far I have

removed the commit that touched the subpage breadcrumbs.
moved community slugs to a method in the PageGroup model.

I'm still researching redirecting users away from xr-network/events to /communities/xr-network/events.

JoshingYou1

Nice refactor Camille! It redirects like a charm now 😄 For V2, we should definitely add a test to cover this scenario.

* Dm 3533 (#543) * DM-3533: Added new component and component image models * DM-3533: Started 'Add Image' functionality * DM-3533: Removed TinyMCE code that was messing with WYSIWYG links * DM-3533: Fixed TinyMCE issues * DM-3533: Added more fields and added delete functionality to component images * DM-3533: Finished all backend functionality * DM-3533: Added some front end code for compound body component * DM-3533: Added configurable bottom and top margin. Cleaned up some code * DM-3533: Added admin panel tests for CompoundBodyComponent * DM-3533: Added a bunch of tests * DM-3533: Added unit tests for new models * DM-3533: Cleaned up some code * DM-3533: Fixed some failing tests * DM-3533: Fixed failing tests * DM-3533: Refactored some code and added another test * DM-3533: Reverted data type for paperclip attachments * DM-3533: Added to Pages show page and a few tests * DM-3533: Added mobile styling and another test * DM-3533: Cleaned up some code * DM-3533: Commented out selenium_chrome line from spec_helper * DM-3533: Added outline to images that belong to a CompoundBodyComponent * DM-3533: Removed unnecessary 'validate' call * DM-3533: Added external link styling to WYSIWYG links for compound body component * DM-3533: Removed some unnecessary code * DM-3533: Cleaned up some JS code * DM-3533: Fixed issue with external link styling for PageComponentImages * DM-3533: Added ':thumb' style to PageComponentImage on Page show page * Dm 3592 anchor tags (#542) * dm-3592 add fix for anchor tag/links in chrome. * dm-3592 build out anchor tags for all Accordions/(FAQs) on a page. * dm-3592 test to ensure accordion component displays * dm-3592 spec - add click event to display accordion text. * dm-3592 spec for accordion * dm-3592 * dm-3508 moved anchor tag to div container instead of above div container. * dm-3592 Add test for multiple accordions and anchor tags. * dm-3508 test * dm-3508 * dm-3508 PR fixes for anchor tags. * Dm 3529 (#546) * DM-3533: Added new component and component image models * DM-3533: Started 'Add Image' functionality * DM-3533: Removed TinyMCE code that was messing with WYSIWYG links * DM-3533: Fixed TinyMCE issues * DM-3533: Added more fields and added delete functionality to component images * DM-3533: Finished all backend functionality * DM-3533: Added some front end code for compound body component * DM-3533: Added configurable bottom and top margin. Cleaned up some code * DM-3533: Added admin panel tests for CompoundBodyComponent * DM-3533: Added a bunch of tests * DM-3533: Added unit tests for new models * DM-3533: Cleaned up some code * DM-3533: Fixed some failing tests * DM-3533: Fixed failing tests * DM-3533: Refactored some code and added another test * DM-3533: Reverted data type for paperclip attachments * DM-3533: Added to Pages show page and a few tests * DM-3533: Added mobile styling and another test * DM-3533: Cleaned up some code * DM-3533: Commented out selenium_chrome line from spec_helper * DM-3533: Added outline to images that belong to a CompoundBodyComponent * DM-3533: Removed unnecessary 'validate' call * DM-3533: Added external link styling to WYSIWYG links for compound body component * DM-3533: Removed some unnecessary code * DM-3533: Cleaned up some JS code * DM-3529: Added image and image alt text fields to page * DM-3533: Added ability to add image to a Page in the admin panel * DM-3533: Fixed issue with external link styling for PageComponentImages * DM-3533: Added ':thumb' style to PageComponentImage on Page show page * DM-3529: Working on frontend for header image * DM-3529: Added mobile styles * DM-3529: Adjusted styles based on design's feedback * DM-3529: Finished writing tests and cleaning up styling * DM-3529: Improved a test * DM-3529: Fixed failing tests * DM-3529: Fixed up the schema and uncommented headless chrome * DM-3529: Removed redundant 'private' call and cleaned up a little bit of code * DM-3534 DM-3561: Add Events and News Components (#544) Co-authored-by: Camille Villa <[email protected]> * Dm 3508 map component (#541) * dm-3508 Adding support/dependencies for map component. * dm-3508 Page Builder UI * dm-3508 * dm-3508 documenting page_map_components schema * dm-3508 backend and infrastructure for front end. * dm-3508 * dm-3508 bus logic: fetching diffusion histories for selected practices. * dm-3508 * dm-3508 center map and zoom * dm-3508 styles, zoom level * dm-3508 Fix query for adopting facilities * dm-3508 removed dbg * dm-3508 removed dbgs * dm-3508 marker infowindow * dm-3508 info window * dm-3508 logic for statuses * dm-3508 front end stuff * dm-3508 info window styling text changes. * dm-3508 border radius.. * dm-3508 map zoom * dm-3508 border padding for info window card style * dm-3508 use padding shorthand * dm-3508 add margin between description and map bottom. * dm-3508 info window static size. * dm-3508 infowindow styles... * dm-3508 Added in Abbr Short_name for info window content.. i.e., 23 "XR" innovations.. for a specific Facility. * dm-3508 margin above num innovations in infowindow * dm-3508 schema change * dm-3508 added test. * dm-3508 * dm-3508 fixed issue with text wrapping and ignoring padding. * dm-3508 info window styles * dm-3508 make map component mobile friendly. * dm-3508 more info window and border styles for map component info window. * dm-3508 * dm-3508 * dm-3508 info window styles * dm-3508 addressing testing and PR comments. * dm-3508 refactored some code to use ActiveRecord vs arrays. * dm-3508 Refactored some code in the controller. * dm-3508 renamed infowindow partial to _page_map_infowindow * dm-3508 another slight refactor... * dm-3508 UPdate based on PR comments. * dm-3508 Fixed styling for Info Window Facility Link. * dm-3508 Map and info window styles.. enums for Diffusion History statuses.. etc. * dm-3508 Addend links for innovations within the map component markers info-window * dm-3508 forgot to update these changes in schema.rb * dm-3508 remove commented code and fix margin in info window. * dm-3508 Added model test. * dm-3508 more tests for map * dm-3508 try to fix test. * dm-3508 Fix test. * dm-3508 * dm-3508 ok.. lets try different syntax.. * m-3508 display-none? * dm-3508 forgot the div * dm-3508 * dm-3508 * dm-3508 * dm-3508 info window styles * dm-3508 * dm-3508 info window size and positioning * dm-3508 * dm-3508 * dm-3508 Style changes per design. * dm-3508 spec for clicking map marker and displaying infowindow * dm-3508 err in spec. * dm-3508 Admin Panel test page for creating a map component * dm-3508 removed debuggers * dm-3508 Admin panel spec * dm-3508 Update IDs to match db change for "display_successful_adoptions" for spec. * Revert "dm-3508" This reverts commit 8e352bd * dm-3508 re-factor spec * dm-3508 more refactor for specs * dm-3508 * dm-3508 info window spec * dm-3508 setting ids back to be consistent in map_page_comonent_form.html.arb * dm-3508 find the map marker... * dm-3508 Remove other community features from schema that are in other component branches. * dm-3508 PR updates. * dm-3508 PR updates * dm-3508 pr suggestions * dm-3508 moved helper method to model - refactored method. * dm-3508 * dm-3508 test not working now... * dm-3508 PR Comments * dm-3508 InfoWindow refactors * dm-3508 Update/Refactor short_name column to map_info_window_text * dm-3508 updated page_map_component.short_name field to map_info_window_text. * dm-3508 Update tests for map due to column name change. * dm-3508 update spec for page_map_component field name change. * dm-3508 pr comments. * dm-3508 INfo Window styles. * dm-3508 Decrease maxWidth and maxHeight * dm-3508 removed commented code from spec. * dm-3508 adjustedpixel offset for new maxWidth, maxHeight. * dm-3508 Fix indent for comment headers. * dm-3508 revert back to "if" instead of "unless" * Removed duplicate code in admin/pages.rb Co-authored-by: Joshua Drumm <[email protected]> * Community Feature replace total adoption count with just count of "adopted practices within the community" * Changed '.count' to '.length' for practice_data array * DM-3626: Refactored grid column setup for 'CompoundBody' component (#549) * Dm compound body spacing fix (#550) * Renamed 'margin' columns to 'padding' and refactored the code to reflect those changes * Reverted some schema changes * Fixed a failing test * Fixed a couple of typos * DM 3631: Support /communities URL for Community pages (#551) Co-authored-by: Camille Villa <[email protected]> Co-authored-by: Joshua Drumm <[email protected]> * DM-3627: Adjusted styles to align with DM homepage styles (#553) * Dm 3632 (#552) * dm-3632 Added XR Network dropdown nav in header. * dm-3632 highlighting/bolding for currently selected menu item * dm-3632 add some tests for nav. * dm-3632 update path info based on community/xr-network routes * dm-3632 PR comments adjustments * dm-3632 test for top nav communities. * dm-3632 test for home page. * dm-3632 test for communities about page. * dm-3632 * dm-3632 * dm-3632 * dm-3632 * dm-3632 revert tests - not working. * dm-3632 this test should work.. * dm-3632 slug needs to be 'home' * dm-3632 change slug back to home. * dm-3632 Adding path tests for all xr-network pages. * dm-3632 adding the pages. * Communities redirect fix (#555) * Fixed community redirect issue and added a test * Improved test scenario description * Trying to fix test on CI * Hopefully fixed test on CI Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Camille Villa <[email protected]> Co-authored-by: Camille Villa <[email protected]> Co-authored-by: bradjohnson92008 <[email protected]>

camillevilla force-pushed the dm-3631-communities-url branch from b734e96 to e21058f Compare October 14, 2022 22:01

camillevilla requested review from JoshingYou1 and bradjohnson92008 October 14, 2022 22:02

camillevilla added 2 commits October 17, 2022 10:23

Update webdrivers to run tests on Mac M1s

3e46669

Accept communities url prefix

ce791e6

camillevilla force-pushed the dm-3631-communities-url branch from 8962a6a to 25757c0 Compare October 17, 2022 17:29

bradjohnson92008 approved these changes Oct 17, 2022

View reviewed changes

JoshingYou1 suggested changes Oct 17, 2022

View reviewed changes

camillevilla added 4 commits October 17, 2022 14:58

Add a test

64c9d18

Communities page breadcrumbs should link back to /communities/home

2613906

Redirect /communities to XR Network home temporarily

f80817c

Move community logic to PageGroup model

0e7d9e2

camillevilla force-pushed the dm-3631-communities-url branch from 25757c0 to 0e7d9e2 Compare October 17, 2022 22:44

JoshingYou1 approved these changes Oct 18, 2022

View reviewed changes

Redirect community pages without /communities in request

f371d66

camillevilla force-pushed the dm-3631-communities-url branch from 3c23e32 to f371d66 Compare October 18, 2022 21:07

camillevilla added 3 commits October 18, 2022 14:17

Add URI parsing to communities path

9072491

Specify HOSTNAME

334aebf

update dependencies google-protobuf and nokogiri

6d778ea

camillevilla force-pushed the dm-3631-communities-url branch from cd38b6d to 6d778ea Compare October 18, 2022 22:09

Trying to fix brakeman redirect issue

2a76da2

camillevilla merged commit 368d3ac into feature/communities Oct 19, 2022

camillevilla deleted the dm-3631-communities-url branch October 19, 2022 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DM 3631: Support /communities URL for Community pages #551

DM 3631: Support /communities URL for Community pages #551

camillevilla commented Oct 14, 2022 •

edited

Loading

bradjohnson92008 left a comment

JoshingYou1 left a comment

JoshingYou1 Oct 17, 2022

camillevilla Oct 17, 2022

JoshingYou1 Oct 17, 2022

JoshingYou1 Oct 17, 2022

camillevilla Oct 17, 2022

camillevilla commented Oct 17, 2022

JoshingYou1 left a comment

DM 3631: Support /communities URL for Community pages #551

DM 3631: Support /communities URL for Community pages #551

Conversation

camillevilla commented Oct 14, 2022 • edited Loading

JIRA issue link

Description - what does this code do?

Testing done - how did you test it/steps on how can another person can test it

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

Definition of done

bradjohnson92008 left a comment

Choose a reason for hiding this comment

JoshingYou1 left a comment

Choose a reason for hiding this comment

JoshingYou1 Oct 17, 2022

Choose a reason for hiding this comment

camillevilla Oct 17, 2022

Choose a reason for hiding this comment

JoshingYou1 Oct 17, 2022

Choose a reason for hiding this comment

JoshingYou1 Oct 17, 2022

Choose a reason for hiding this comment

camillevilla Oct 17, 2022

Choose a reason for hiding this comment

camillevilla commented Oct 17, 2022

JoshingYou1 left a comment

Choose a reason for hiding this comment

camillevilla commented Oct 14, 2022 •

edited

Loading