Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VACMS-20282]Update facility hours copy, size, and add sub message #2421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SnowboardTechie
Copy link
Contributor

@SnowboardTechie SnowboardTechie commented Jan 23, 2025

Summary

  • Updated the displaying of 24/7 facility hours to be more inline with the styles as well as provide a clear message to veterans
  • Not a bug, just copy changes
  • Sitewide team owns and maintains this component
  • No flippers for this copy change

Related issue(s)

Testing done

  • Prior to this change, visiting a VAMC w/ 24/7 hours like Minneapolis, will display the existing Clinical hours h2 along with no warning. On this branch with a fresh content build you will find Clinical adjust to Facility at the more appropriate h3 size along with a warning about hours differing depending on services required.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile Screenshot 2025-01-23 at 8 10 06 AM Screenshot 2025-01-23 at 8 05 27 AM
Desktop Screenshot 2025-01-23 at 8 10 38 AM Screenshot 2025-01-23 at 8 05 09 AM

What areas of the site does it impact?

This impacts the hours template used for displaying hours for various facilities, these adjustments specifically only apply to "clinical" facilities.

Acceptance criteria

  • "Clinical Hours" is changed to read "Facility Hours"

  • Currently h2 "Facility Hours" heading is changed to a h3 heading level to match "Address" and "Phone numbers" headings

  • Paragraph is added that states: "Hours may vary for different services. Select a service on this page to check the hours." Should match VBA, example

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed (this link is broken)

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@SnowboardTechie
Copy link
Contributor Author

This PR is now ready for review. Marking as do not merge to avoid confusion until editors have been notified of this change department-of-veterans-affairs/va.gov-cms#20064 (comment)

@SnowboardTechie SnowboardTechie marked this pull request as ready for review January 23, 2025 16:12
@SnowboardTechie SnowboardTechie requested review from a team as code owners January 23, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants