Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VACMS-19406]Don't build health care region pages for Manila #2410

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

SnowboardTechie
Copy link
Contributor

@SnowboardTechie SnowboardTechie commented Jan 8, 2025

Summary

  • Makes it so that even when published, system nodes for Manila's VA Clinic will not be built
  • It was desired to put this in as a safety net in case future editors accidentally publish this system node
  • Sitewide Team
  • No Flipper

Related issue(s)

Testing done

What areas of the site does it impact?

Manila System Node

Acceptance criteria

  • Manila VAMC System node is published in Drupal, but no FE page generated

  • Manila VAMC System page can't make it through content-build to the FE

  • Regression test FE in a tugboat and ensure that all URLs match the IA document in SharePoint.AMC

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@SnowboardTechie SnowboardTechie self-assigned this Jan 8, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 8, 2025 15:35 Inactive
@SnowboardTechie SnowboardTechie force-pushed the vacms-19406-dont-build-manila-vamc-system-node branch from 0ac8538 to 2c43bdb Compare January 8, 2025 20:41
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 8, 2025 20:58 Inactive
@SnowboardTechie SnowboardTechie force-pushed the vacms-19406-dont-build-manila-vamc-system-node branch from 2c43bdb to 25f7477 Compare January 9, 2025 15:01
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 9, 2025 16:49 Inactive
@SnowboardTechie SnowboardTechie force-pushed the vacms-19406-dont-build-manila-vamc-system-node branch from e40a236 to ff6946e Compare January 9, 2025 17:45
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 9, 2025 18:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 9, 2025 18:53 Inactive
@SnowboardTechie SnowboardTechie force-pushed the vacms-19406-dont-build-manila-vamc-system-node branch from f8cd289 to 6790123 Compare January 16, 2025 16:35
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 16, 2025 17:03 Inactive
@SnowboardTechie SnowboardTechie force-pushed the vacms-19406-dont-build-manila-vamc-system-node branch from 6790123 to 2e3aa63 Compare January 16, 2025 18:08
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 16, 2025 19:00 Inactive
@SnowboardTechie SnowboardTechie force-pushed the vacms-19406-dont-build-manila-vamc-system-node branch from 2e3aa63 to 1e42fe7 Compare January 16, 2025 19:00
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/vacms-19406-dont-build-manila-vamc-system-node January 16, 2025 19:28 Inactive
@SnowboardTechie SnowboardTechie marked this pull request as ready for review January 17, 2025 21:48
@SnowboardTechie SnowboardTechie requested review from a team as code owners January 17, 2025 21:48
@jilladams jilladams requested a review from timcosgrove January 18, 2025 00:49
@jilladams
Copy link
Contributor

Adding @timcosgrove for awareness, since the fact of Manila missing a built System page is a consideration for AP. FYI this is how we plan to make sure it never makes a page.

@jilladams
Copy link
Contributor

@SnowboardTechie are we just in the holding pattern waiting on Platform PR review on this? Feel free to file a Platform support request to ask for review today -- I think you're within rights at this point.

@SnowboardTechie
Copy link
Contributor Author

@SnowboardTechie are we just in the holding pattern waiting on Platform PR review on this? Feel free to file a Platform support request to ask for review today -- I think you're within rights at this point.

@jilladams that's correct, we are holding on their review. I went ahead and put in that support request here

@SnowboardTechie SnowboardTechie merged commit deaf791 into main Jan 22, 2025
24 checks passed
@SnowboardTechie SnowboardTechie deleted the vacms-19406-dont-build-manila-vamc-system-node branch January 22, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants