Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS 17954 - remove italics from common conditions #2238

Merged
merged 2 commits into from
Aug 19, 2024
Merged

VACMS 17954 - remove italics from common conditions #2238

merged 2 commits into from
Aug 19, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Aug 14, 2024 •
edited
Loading

Summary

  • Removes span with italics font style on common conditions
  • Sitewide team

Related issue(s)

Testing done

  • Old behavior was italics text for the words "Common conditions" in health services

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Service Accordions Screenshot 2024-08-14 at 1 55 07 PM Screenshot 2024-08-14 at 1 54 50 PM

What areas of the site does it impact?

Health Services of region and VAMC facility.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (unauthenticated)

Requested Feedback

Check RI/boston-health-care/locations/brockton-va-medical-center/#geriatrics
and
/boston-health-care/health-services/ (scroll down to Geriatrics, no hash shortcuts)

@eselkin eselkin marked this pull request as ready for review August 14, 2024 20:57
@eselkin eselkin requested a review from a team as a code owner August 14, 2024 20:57
@eselkin eselkin requested a review from randimays August 15, 2024 20:27
randimays
randimays approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eselkin eselkin merged commit 62f23ba into main Aug 19, 2024
23 checks passed
@eselkin eselkin deleted the VACMS-17954-unitalicize-common-conditions branch August 19, 2024 06:21
davidmpickett added a commit that referenced this pull request Sep 17, 2024
@davidmpickett @eselkin
@Andrew565 @kjduensing @micahchiang @aubreyarcangel @GovCIOLiz @vetskrieg @reiting @randimays @GcioNapoleon @rmessina1010 @nihil2501 @govcioChad @asg5704
Rebasing PR (#2276)
835fe67 
* VACMS 17954 - remove italics from common conditions (#2238)

* VACMS 17954 - remove italics
* move to p instead of div

* VACMS 16362: Make only published Vet Center Services display (#2243)

* filterBy status:true services
* fix accordion labeling ids
* remove debugging

* Adding arrow_circle_right to sprite sheet (#2244)

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* bump web-components (#2258)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-424 React SCO page to prod (#2253)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* direct links to hashreference of taxonomy name in facility (#2262)

* VACMS 18711 - vet center banner image (#2251)

* VC Banner image

* Add entry for Benefit Eligibility Questionnaire (#2170)

* update FMP name (#2257)

Co-authored-by: Rachel <[email protected]>

* VACMS-18876 Fix breadcrumbs on checklist pages (#2266)

* VEBT-468 remove 1990E from registry.json (#2260)

* VEBT-468 Remove 1990e from production.

* VEBT-468 remove 1990E from registry.json

* Add  navigation svg icons to site/img  directory (#2237)

* adds svgs for nav icons

* correct svg icon

* remove custom event (#2263)

* [ARF-87799] Remove 21a (#2269)

[Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352)

* #vebt-469 remove 1990s from registry.json (#2261)

Co-authored-by: Chad Chotikasatien <[email protected]>

* add sign-in-changes app to registry (#2271)

* Updating web-components version to latest (#2272)

* wrapping (#2268)

* #vebt-470 #removing 22-1990n entry in registry.json (#2264)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* #vebt-470 #removing 22-1990n entry in registry.json

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: GovCIOLiz <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: GovCIOLiz <[email protected]>
Co-authored-by: Chad Chotikasatien <[email protected]>

* VACMS-18855 Add Find Forms download modal back to form detail page (#2239)

* VACMS-18855 Add Find Forms download modal back to form detail page

* adding ID to container

* Add feature flag

* finishing up feature flag

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: GovCIOLiz <[email protected]>
Co-authored-by: Aaron Kriegler <[email protected]>
Co-authored-by: Rachel Eiting <[email protected]>
Co-authored-by: Rachel <[email protected]>
Co-authored-by: Randi Mays <[email protected]>
Co-authored-by: Napoleon K. <[email protected]>
Co-authored-by: Ray Messina <[email protected]>
Co-authored-by: Oren Mittman <[email protected]>
Co-authored-by: govcioChad <[email protected]>
Co-authored-by: Chad Chotikasatien <[email protected]>
Co-authored-by: Alexander Garcia <[email protected]>
Co-authored-by: GovCIOLiz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randimays randimays randimays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eselkin @randimays @va-vfs-bot