Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prefill pattern components in Storybook #1456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bellepx0
Copy link
Contributor

@bellepx0 bellepx0 commented Jan 15, 2025

Chromatic

https://update-prefill-pattern-components--65a6e2ed2314f7b8f98609d8.chromatic.com


Description

This PR updates the Prefill pattern components to align with the latest changes in the Prefill pattern

Changes

  • Components/Card

    • Updated Editable and Uneditable cards
  • Components/Prefill Alert

    • Updated Signed In Prefill Alert
    • Removed Prefill info alert
  • Usage Examples

    • Updated "Prefill alert with editable card" to "Prefilled info with editable card" (removed prefill alert)
    • Updated "Prefilled info with uneditable card" to include new uneditable card design
    • Updated "Signed In Prefill Alert" to include new alert

Closes Authenticated Experience Design Patterns team ticket

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Prefill Pattern folder structure in Storybook
Screenshot 2025-01-15 at 11 12 48 AM

Editable card component
Screenshot 2025-01-15 at 11 13 40 AM

Uneditable card component
Screenshot 2025-01-15 at 11 14 04 AM

Signed in prefill alert component
Screenshot 2025-01-15 at 1 53 29 PM

Usage Example: Prefilled info with editable card
Screenshot 2025-01-15 at 11 15 08 AM

Usage Example: Prefilled info with uneditable card
Screenshot 2025-01-15 at 11 16 52 AM

Usage Example: Signed in prefill alert
Screenshot 2025-01-15 at 1 53 44 PM

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Used if you want to ignore the PR in the generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant