Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FORMATION_MIGRATION.md #1454

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Create FORMATION_MIGRATION.md #1454

merged 3 commits into from
Jan 17, 2025

Conversation

micahchiang
Copy link
Contributor

@micahchiang micahchiang commented Jan 14, 2025

Chromatic

https://mc-formation-migration-docs--65a6e2ed2314f7b8f98609d8.chromatic.com


Configuring this pull request

  • Link to any related issues in the description so they can be cross-referenced.
  • Add the appropriate version patch label (major, minor, patch, or ignore-for-release).
    • See How to choose a version number for guidance.
    • Use ignore-for-release if files haven't been changed in a component library package. (ie. only Storybook files)

Description

Closes 3623

QA Checklist - not applicable

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@micahchiang micahchiang added the ignore-for-release Used if you want to ignore the PR in the generated release notes label Jan 14, 2025
@micahchiang micahchiang requested a review from a team as a code owner January 14, 2025 18:15
Copy link
Contributor

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be very useful!

@@ -0,0 +1,102 @@
## Background
In December 2024 the design system team sunsetted Formation in vets-website in favor of [css library](https://github.com/department-of-veterans-affairs/component-library/tree/main/packages/css-library). Though migration has been completed for vets-website, content-build, and next-build, there may be some external teams that are still looking to migrate over. This documentation outlines necessary configuration for integrating css library into a stand alone project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where it says "css library" or "css-library" as a noun throughout, should we make it capitalized consistently? ie. CSS Library

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed but I would vote for "CSS-Library" with the hyphen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry it's inconsistent. My vote is for "css-library", since that's the name of the actual package, so we can compromise and go with Andrew's suggestion which seems like a happy medium 😄

In December 2024 the design system team sunsetted Formation in vets-website in favor of [css library](https://github.com/department-of-veterans-affairs/component-library/tree/main/packages/css-library). Though migration has been completed for vets-website, content-build, and next-build, there may be some external teams that are still looking to migrate over. This documentation outlines necessary configuration for integrating css library into a stand alone project.

## Installation
We recommend installing css-library as a dependency in your package.json file. It can be installed [via npm](https://www.npmjs.com/package/@department-of-veterans-affairs/css-library?activeTab=readme). If you're unable to use a package.json file to manage dependencies, then you may be able to import stylesheets using a cdn like unpkg. Files can be grabbed [here](https://unpkg.com/browse/@department-of-veterans-affairs/[email protected]/dist/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to unkpg is going to a specific version. Is there a way we could point to where it can be linked without using a version that will become obsolete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, I'll try and update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm the URL needs a version, but I'll add a note stating users will need to use the select dropdown on the right to select the latest version.

image


If your application needs VADS utility classes, add this import to your application stylesheet:

`@import "~@department-of-veterans-affairs/css-library/dist/stylesheets/utilities`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the utilities section need any clarification about the grid classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea 👍

Signed-off-by: Micah Chiang <[email protected]>
@micahchiang micahchiang merged commit 2d2d0c5 into main Jan 17, 2025
8 checks passed
@micahchiang micahchiang deleted the mc-formation-migration-docs branch January 17, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Used if you want to ignore the PR in the generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft documentation for how teams can migrate to CSS Library
3 participants