va-alert-expandable & va-alert-sign-in: fix Storybook link to guidance #1449

jamigibbs · 2025-01-09T22:08:30Z

Chromatic

This will fix the guidance links for va-alert-expandable and va-alert-sign-in. It will also display the maturity circle for va-alert-sign-in.

Component maintains 1:1 parity with design mocks
Text is consistent with what's been provided in the mocks
Component behaves as expected across breakpoints
Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
Designer has signed off on changes (if applicable. If not applicable provide reason why)
Tab order and focus state work as expected
Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
New components are covered by e2e tests; updates to existing components are covered by existing test suite
Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Documentation has been updated, if applicable
A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

powellkerry

LGTM

fix alert link to guidance

2040df8

jamigibbs added the ignore-for-release Used if you want to ignore the PR in the generated release notes label Jan 9, 2025

jamigibbs marked this pull request as ready for review January 9, 2025 22:14

jamigibbs requested a review from a team as a code owner January 9, 2025 22:14

powellkerry approved these changes Jan 9, 2025

View reviewed changes

jamigibbs merged commit 741a349 into main Jan 9, 2025
10 checks passed

jamigibbs deleted the va-alert-sign-in-storybook branch January 9, 2025 22:43