css-library: Fixing the html element's font-size so it will respect browser settings #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataker
approved these changes
Dec 24, 2024
jamigibbs
requested changes
Dec 26, 2024
| @@ -11,7 +11,7 @@ body { | |||
| } | |||
|
|
|||
| html { | |||
| font-size: $em-base; | |||
| font-size: 100%; // Needs to be 100% to be able to grow and shrink with browser settings | |||
There was a problem hiding this comment.
This was changed to 16px because of root font size updates related to USWDS v3 (it previously being 10px). Was this tested using Verdaccio to make sure everything still looks correct by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://3646-fix-browser-font-sizing--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
Closes #3646
QA Checklist
N/A
Screenshots
N/A
Acceptance criteria
Definition of done