Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-process-list: add ability to customize eyebrow status text #1422

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

powellkerry
Copy link
Contributor

@powellkerry powellkerry commented Dec 2, 2024

Chromatic

https://3500-process-list-eyebrow--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

Adds a prop to va-process-list-item to allow the eyebrow status text to be customized. If no value is supplied the original static text will be displayed.

Closes department-of-veterans-affairs/vets-design-system-documentation#3500

QA Checklist

  • [ x] Component maintains 1:1 parity with design mocks
  • [ x] Text is consistent with what's been provided in the mocks
  • [ x] Component behaves as expected across breakpoints
  • [ x] Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • [ x] Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • [ x] Tab order and focus state work as expected
  • [ x] Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • [ x] New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • [ x] Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Before:
Screenshot 2024-12-02 at 2 47 01 PM

After:
Screenshot 2024-12-02 at 2 47 37 PM

Acceptance criteria

  • [ x] QA checklist has been completed
  • [ x] Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • [ x] Documentation has been updated, if applicable
  • [ x] A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@powellkerry powellkerry added the minor For a minor Semantic Version change label Dec 2, 2024
@powellkerry powellkerry requested a review from a team as a code owner December 2, 2024 21:55
@powellkerry powellkerry merged commit 28824e7 into main Dec 3, 2024
8 checks passed
@powellkerry powellkerry deleted the 3500-process-list-eyebrow branch December 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For a minor Semantic Version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Eyebrows on Status List not Configurable
2 participants