Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

va-search-input: remove v1 code #1278

Merged
merged 4 commits into from
Aug 14, 2024
Merged

va-search-input: remove v1 code #1278

merged 4 commits into from
Aug 14, 2024

Conversation

it-harrison
Copy link
Contributor

@it-harrison it-harrison commented Aug 13, 2024 •
edited by github-actions bot
Loading

Chromatic

https://search-input-v1-removal--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

This PR removes v1 code from va-search-input
Closes 3023

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@it-harrison it-harrison added the minor For a minor Semantic Version change label Aug 13, 2024
@it-harrison it-harrison requested a review from a team as a code owner August 13, 2024 21:28
@powellkerry
Copy link
Contributor

powellkerry commented Aug 14, 2024 •
edited
Loading

I think there are some style discrepancies between this branch and prod dealing with width:
Prod:
Screenshot 2024-08-14 at 8 26 11 AM

Chromatic:
Screenshot 2024-08-14 at 8 26 40 AM

powellkerry
powellkerry reviewed Aug 14, 2024
View reviewed changes
packages/web-components/src/components/va-search-input/test/va-search-input.e2e.ts Outdated
@@ -903,15 +470,15 @@ describe('va-search-input', () => {

it('uswds displays as the small variation', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uswds could probably be removed from these test titles, but not a big deal if you don't get to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powellkerry - good catch, fixed

@it-harrison it-harrison merged commit 03035ec into main Aug 14, 2024
8 checks passed
@it-harrison it-harrison deleted the search-input-v1-removal branch August 14, 2024 21:09
@jamigibbs jamigibbs added major Major change in semantic versioning and removed minor For a minor Semantic Version change labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powellkerry powellkerry powellkerry approved these changes

Assignees
No one assigned
Labels
major Major change in semantic versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V1 Component Code Removal - va-search-input
3 participants
@it-harrison @powellkerry @jamigibbs