va-statement-of-truth: reflect error prop in va-text-input for styling #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamigibbs
commented
Aug 5, 2024
| @@ -54,7 +54,7 @@ export class VaTextInput { | |||
| /** | |||
| * The error message to render. | |||
| */ | |||
| @Prop() error?: string; | |||
| @Prop({ reflect: true }) error?: string; | |||
There was a problem hiding this comment.
reflect will add the prop to the component's markup in the DOM which is how the error styles are applied.
Reference: https://stenciljs.com/docs/properties#reflect-properties-values-to-attributes-reflect
| */ | ||
| componentDidRender() { | ||
| if (this.inputError) { | ||
| this.inputField.setAttribute('error', this.inputError); |
There was a problem hiding this comment.
With the error prop now rendering as an attribute on the va-text-input component using reflect, this logic is no longer necessary.
powellkerry
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://3065-statement-of-truth--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
This update will make sure that the
errorprop is being reflected on to theva-text-inputmarkup element in the DOM so that error styling will apply to it. It also cleans up the previous solution that is no longer necessary because of that update.This will fix error styling inconsistencies reported in the issue below.
Closes department-of-veterans-affairs/vets-design-system-documentation#3065
Screenshots
QA Checklist
Acceptance criteria
Definition of done