Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VA.gov doesn't respect Chrome browser font resizing anymore #3646

Open
1 of 6 tasks
laflannery opened this issue Dec 23, 2024 · 2 comments · May be fixed by department-of-veterans-affairs/component-library#1444
Open
1 of 6 tasks
Labels
bug Something isn't working DST-engineering Issues that require work from Design System Team engineers new-unplanned Unplanned work added to a sprint platform-design-system-team

Comments

@laflannery
Copy link

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

When the typography updates first happened earlier this year, the VA.gov website was finally respecting browser font settings. However, this doesn't happen anymore on the VA.gov website.

What I expected to happen

What I expected to happen was that the font would become very large when I set the font to "Very Large". This used to happen up until 12/6/24 according to the Way back machine. You can see the change clearly here:

It seems that something happened/was merged during 12/6 that caused this changed on the website.

Reproducing

  • Formation version:
  • Device: (e.g. iPhone 8, Macbook)
  • Browser: (e.g. Firefox, IE 11)

Steps to reproduce:

  1. Go into Chrome > Settings > Appearance > Font size
  2. Change your font settings to something other than the default
  3. The font on the website should respond to your new settings.
  4. Notice that the font no longer changes size depending on the setting you have set

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

This bug is not blocking work but it is and accessibility issue and is blocking access to the website for users that depend on larger font sizes to be able to read and see the text clearly.

@laflannery laflannery added bug Something isn't working platform-design-system-team labels Dec 23, 2024
@caw310 caw310 added new-unplanned Unplanned work added to a sprint DST-engineering Issues that require work from Design System Team engineers labels Dec 23, 2024
@Andrew565
Copy link
Contributor

Was able to confirm this bug, not able to pinpoint why as of yet. Temporary workaround is to instruct users to increase the page zoom instead of the font sizes, zoom still works.

@Andrew565
Copy link
Contributor

Laura discovered that core.css is setting the html element's font-size to 16px instead of 100% (see screenshot attached). I was able to manually edit it with the browser's dev tools back to 100% and the "Very Large" font setting worked again.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DST-engineering Issues that require work from Design System Team engineers new-unplanned Unplanned work added to a sprint platform-design-system-team
Projects
None yet
3 participants