Merge branch 'main' into 3606-va-link-aria-label

department-of-veterans-affairs · Jan 13, 2025 · ff2b80b · ff2b80b
2 parents 7b7474c + d564cf0
commit ff2b80b
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 14 deletions.
diff --git a/packages/web-components/src/components.d.ts b/packages/web-components/src/components.d.ts
@@ -113,6 +113,7 @@ export namespace Components {
     }
     /**
      * @componentName Alert - expandable
+     * @guidanceHref alert/alert-expandable
      * @maturityCategory caution
      * @maturityLevel candidate
      */
@@ -135,7 +136,8 @@ export namespace Components {
         "trigger": string;
     }
     /**
-     * @componentName Alert - Sign In
+     * @componentName Alert - Sign-in
+     * @guidanceHref alert/alert-sign-in
      * @maturityCategory caution
      * @maturityLevel candidate
      */
@@ -2153,6 +2155,7 @@ declare global {
     }
     /**
      * @componentName Alert - expandable
+     * @guidanceHref alert/alert-expandable
      * @maturityCategory caution
      * @maturityLevel candidate
      */
@@ -2171,7 +2174,8 @@ declare global {
         new (): HTMLVaAlertExpandableElement;
     };
     /**
-     * @componentName Alert - Sign In
+     * @componentName Alert - Sign-in
+     * @guidanceHref alert/alert-sign-in
      * @maturityCategory caution
      * @maturityLevel candidate
      */
@@ -3342,6 +3346,7 @@ declare namespace LocalJSX {
     }
     /**
      * @componentName Alert - expandable
+     * @guidanceHref alert/alert-expandable
      * @maturityCategory caution
      * @maturityLevel candidate
      */
@@ -3368,7 +3373,8 @@ declare namespace LocalJSX {
         "trigger": string;
     }
     /**
-     * @componentName Alert - Sign In
+     * @componentName Alert - Sign-in
+     * @guidanceHref alert/alert-sign-in
      * @maturityCategory caution
      * @maturityLevel candidate
      */
@@ -5444,12 +5450,14 @@ declare module "@stencil/core" {
             "va-alert": LocalJSX.VaAlert & JSXBase.HTMLAttributes<HTMLVaAlertElement>;
             /**
              * @componentName Alert - expandable
+             * @guidanceHref alert/alert-expandable
              * @maturityCategory caution
              * @maturityLevel candidate
              */
             "va-alert-expandable": LocalJSX.VaAlertExpandable & JSXBase.HTMLAttributes<HTMLVaAlertExpandableElement>;
             /**
-             * @componentName Alert - Sign In
+             * @componentName Alert - Sign-in
+             * @guidanceHref alert/alert-sign-in
              * @maturityCategory caution
              * @maturityLevel candidate
              */

diff --git a/packages/web-components/src/components/va-alert-expandable/va-alert-expandable.tsx b/packages/web-components/src/components/va-alert-expandable/va-alert-expandable.tsx
@@ -13,6 +13,7 @@ import classnames from 'classnames';
 
 /**
  * @componentName Alert - expandable
+ * @guidanceHref alert/alert-expandable
  * @maturityCategory caution
  * @maturityLevel candidate
  */

diff --git a/packages/web-components/src/components/va-alert-sign-in/va-alert-sign-in.tsx b/packages/web-components/src/components/va-alert-sign-in/va-alert-sign-in.tsx
@@ -4,7 +4,8 @@ import { AlertSignInVariants as ASIVariants } from './AlertSignInVariants';
 import { getHeaderLevel } from '../../utils/utils';
 
 /**
- * @componentName Alert - Sign In
+ * @componentName Alert - Sign-in
+ * @guidanceHref alert/alert-sign-in
  * @maturityCategory caution
  * @maturityLevel candidate
  */
@@ -136,13 +137,15 @@ export class VaAlertSignIn {
         <p>
           <slot name="SignInButton"></slot>
         </p>
-        <p>
-          <va-link
-            href={this.noSignInLink}
-            text="Start your form without signing in"
-            disableAnalytics={true}
-          ></va-link>
-        </p>
+        {this.noSignInLink && (
+          <p>
+            <va-link
+              href={this.noSignInLink}
+              text="Start your form without signing in"
+              disableAnalytics={true}
+            ></va-link>
+          </p>
+        )}
       </div>
     );
 

diff --git a/packages/web-components/src/components/va-date/va-date.tsx b/packages/web-components/src/components/va-date/va-date.tsx
@@ -267,7 +267,6 @@ export class VaDate {
               onBlur={this.handleMonthBlur}
               invalid={this.invalidMonth}
               class="select-month"
-              aria-label="Please enter two digits for the month"
               error={this.monthTouched && this.invalidMonth ? error : null}
               showError={false}
             >
@@ -290,7 +289,6 @@ export class VaDate {
                 onBlur={this.handleDayBlur}
                 invalid={this.invalidDay}
                 class="select-day"
-                aria-label="Please enter two digits for the day"
                 error={this.dayTouched && this.invalidDay ? this.error : null}
                 showError={false}
               >