Fix action forbidden error #9923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lowell Wood <[email protected]>
ghost
assigned 
lowellrex
reviewed
Mar 13, 2019
| visit "/queue" | ||
| vet_name = assigned_task.appeal.veteran_full_name | ||
| expect(page).to have_content("#{vet_name.split(' ').first} #{vet_name.split(' ').last}") | ||
| # how to tell if the link is bold? |
There was a problem hiding this comment.
It looks like capybara has a style() method that we might be able to use.
Alternatively, we could just check that the status changed (and doesn't for attorneys viewing ColocatedTasks) and assume that we will be using that information to bold/unbold the link or check to see if the function the endpoint calls is called (expect_any_instance_of(TasksController).to receive(:update).exactly(1).times or something like that).
added 3 commits
March 13, 2019 09:46
…x-action-forbidden-error
…x-action-forbidden-error
tomas-nava
changed the title
tomas-nava
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9613
Description
Only attempt to change a task's status to
in_progressif the user is colocated, because they're the only users who see bold links in the queue for cases they haven't visited yet. This is a temporary fix to silence errors until we tackle #9916