Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RoundRobinTaskDistributor #9531

Merged
merged 9 commits into from
Feb 20, 2019
Merged

Refactor RoundRobinTaskDistributor #9531

merged 9 commits into from
Feb 20, 2019

Conversation

tomas-nava
Copy link
Contributor

Resolves #8535

Description

Refactors the RoundRobinTaskDistributor to

  • use an assignee_pool instead of a list_of_assignees
  • populate that pool with User objects instead of css_ids
  • move the check on an empty assignee_pool to a validation
  • validate the contents of the assignee_pool and the presence of the task_class

Acceptance Criteria

  • Automated test coverage is thorough

@ghost ghost assigned tomas-nava Feb 20, 2019
@ghost ghost added the In-Progress label Feb 20, 2019
@lowellrex lowellrex mentioned this pull request Feb 20, 2019
Closed
lowellrex
lowellrex approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@lowellrex lowellrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Release away!

@tomas-nava tomas-nava added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Feb 20, 2019
@ghost ghost assigned va-bot Feb 20, 2019
@va-bot va-bot merged commit b0d0a9c into master Feb 20, 2019
@va-bot va-bot deleted the queue/tomas/8535-refactor-round-robin-task-distributor branch February 20, 2019 20:10
@ghost ghost removed the In-Progress label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowellrex lowellrex lowellrex approved these changes

Assignees

@va-bot va-bot

@tomas-nava tomas-nava

Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomas-nava @lowellrex @va-bot