Hide hearing worksheet and details links from VSO users #9463
Conversation
ghost
assigned 
| let(:attorney_first_name) { "Robby" } | ||
| let(:attorney_last_name) { "McDobby" } | ||
| let(:attorney_first_name) { "Chanel" } | ||
| let(:attorney_last_name) { "Afshari" } |
| scroll_element_in_to_view("#hearings-section") | ||
| expect(page).to_not have_content("View VLJ Hearing Worksheet") | ||
| expect(page).to_not have_css("a[href='/hearings/#{hearing.external_id}/worksheet/print?keep_open=true']") | ||
| expect(page).to_not have_content("View Hearing Details") |
There was a problem hiding this comment.
I'd replace these strings here with their equivalents from COPY.json: COPY::CASE_DETAILS_HEARING_DETAILS_LINK_COPY
There was a problem hiding this comment.
fixed with this commit.
|
|
||
| expect(page).to have_current_path("/queue/appeals/#{appeal.vacols_id}") | ||
| scroll_element_in_to_view("#hearings-section") | ||
| expect(page).to_not have_content("View VLJ Hearing Worksheet") |
There was a problem hiding this comment.
COPY::CASE_DETAILS_HEARING_WORKSHEET_LINK_COPY
There was a problem hiding this comment.
fixed with this commit.
| </Link> | ||
| }]; | ||
|
|
||
| if (!userIsVsoEmployee) { |
There was a problem hiding this comment.
This seems fine to me, but I think the method would be much more readable if it follows one path if userIsVsoEmployee and another path if !userIsVsoEmployee, so something like:
let hearingAttrs;
if (userIsVsoEmployee) {
hearingAttrs = [{
...
]};
} else (
hearingAttrs = [{
...
}];
}There was a problem hiding this comment.
I hear you, but there are multiple conditions being checked to compose this list (the values of userIsVsoEmployee, hearing.disposition, and hearing.viewedByJudge all affect how the "Disposition" element is rendered) which means there are more than two paths.
tomas-nava
added
the
Ready-to-Merge
va-bot
deleted the
queue/tomas/8793-hide-hearing-worksheet-link-from-vsos
branch
Resolves #8793
Description
Hides the Hearing Worksheet and Hearing Details links from VSO users.
before:
after:
