-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate between judge assign and review views with the queue selector dropdown component #9035
Merged
va-bot
merged 8 commits into
master
from
queue/tomas/8119-go-to-judge-assign-view-with-queue-selector-dropdown
Jan 31, 2019
Merged
Navigate between judge assign and review views with the queue selector dropdown component #9035
va-bot
merged 8 commits into
master
from
queue/tomas/8119-go-to-judge-assign-view-with-queue-selector-dropdown
Jan 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn QueueSelectorDropdown into a general class that other types of dropdowns can inherit from; make QueueOrganizationSelectorDropdown to recreate existing functionality, create QueueJudgeViewSelectorDropdown for new judge view navigation functionality.
joeyyang
reviewed
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments, any questions just ping me!
client/app/queue/components/QueueOrganizationSelectorDropdown.jsx
Outdated
Show resolved
Hide resolved
- rename classes, variables, functions to be more descriptive - construct the organization list in a more readable way
…-to-judge-assign-view-with-queue-selector-dropdown
joeyyang
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ith-queue-selector-dropdown
lowellrex
added
the
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
label
Jan 31, 2019
ghost
assigned lowellrex
Jan 31, 2019
va-bot
deleted the
queue/tomas/8119-go-to-judge-assign-view-with-queue-selector-dropdown
branch
January 31, 2019 15:10
ghost
removed
the
In-Progress
label
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8119
Before:
After: