Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate between judge assign and review views with the queue selector dropdown component #9035

Conversation

tomas-nava
Copy link
Contributor

Resolves #8119

Before:

judge-nav-before

After:

judge-nav-after

Tomas Apodaca added 3 commits January 29, 2019 10:31
Turn QueueSelectorDropdown into a general class that other types of
dropdowns can inherit from; make QueueOrganizationSelectorDropdown to
recreate existing functionality, create QueueJudgeViewSelectorDropdown
for new judge view navigation functionality.
@ghost ghost assigned tomas-nava Jan 29, 2019
@ghost ghost added the In-Progress label Jan 29, 2019
Copy link
Contributor

@joeyyang joeyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, any questions just ping me!

client/app/queue/components/QueueSelectorDropdown.jsx Outdated Show resolved Hide resolved
client/COPY.json Outdated Show resolved Hide resolved
Tomas Apodaca added 3 commits January 29, 2019 11:50
- rename classes, variables, functions to be more descriptive
- construct the organization list in a more readable way
…-to-judge-assign-view-with-queue-selector-dropdown
Copy link
Contributor

@joeyyang joeyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lowellrex lowellrex added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jan 31, 2019
@ghost ghost assigned lowellrex Jan 31, 2019
@va-bot va-bot merged commit 93d2468 into master Jan 31, 2019
@va-bot va-bot deleted the queue/tomas/8119-go-to-judge-assign-view-with-queue-selector-dropdown branch January 31, 2019 15:10
@ghost ghost removed the In-Progress label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants