Add Hearing icon to queue/case views #8904
Conversation
ghost
assigned 
| @@ -46,7 +46,7 @@ const HearingBadge = ({ hearing }) => { | |||
| </div>; | |||
|
|
|||
| // We expect this badge to be shown in a table, so we use this to get rid of the standard table padding. | |||
| return <div {...css({ marginRight: '-3rem' })} className="cf-hearing-badge"> | |||
| return <div {...css({ marginRight: '-2.5rem' })} className="cf-hearing-badge"> | |||
There was a problem hiding this comment.
Why did we need to make this change?
There was a problem hiding this comment.
This spacing works well in all the contexts that the badge shows up in.
…ent-of-veterans-affairs/caseflow into joey-hearing-badge-queue
…ent-of-veterans-affairs/caseflow into joey-hearing-badge-queue
joeyyang
changed the title
joeyyang
changed the title
|
back to you! |
| const mapStateToProps = (state, ownProps) => { | ||
| let externalId, hearing; | ||
|
|
||
| if (ownProps.hearing) { |
There was a problem hiding this comment.
accept either a hearing or a task
|
Looks good! Can we add a few tests to make sure the hearing icon shows up as we expect (and doesn't) on the case search page and on a queue table view? |
Case search hearing badge tests can be found here in search_spec.rb, and I'll add tests for the queue table view now! |
| @@ -79,7 +79,7 @@ | |||
|
|
|||
| scenario "Entire set of attributes for hearing are displayed" do | |||
| visit "/queue" | |||
| page.find(:xpath, "//tr[@id='table-row-#{appeal.vacols_id}']/td[1]/a").click | |||
| page.find(:xpath, "//tr[@id='table-row-#{appeal.vacols_id}']/td[2]/a").click | |||
There was a problem hiding this comment.
What do you think about spinning this pattern out to its own helper function? I imagine something like the click_dropdown function perhaps with a signature like find_table_cell(id: appeal.vacols_id, row_header: COPY::CASE_LIST_TABLE_VETERAN_NAME_COLUMN_TITLE).
There was a problem hiding this comment.
Will make this change in a separate PR!
joeyyang
added
the
Ready-to-Merge
joeyyang
removed
the
Ready-to-Merge
joeyyang
added
the
Ready-to-Merge
Resolves #7478
Description
Adds the
HearingBadge"H" to all<TaskTable>s and loads them asynchronously.ex.
