Add link/button to show/hide task instructions #8431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rkreyhsig
changed the title
lowellrex
reviewed
Dec 28, 2018
client/app/queue/TaskSnapshot.jsx
Outdated
| name={(this.state.taskInstructionsIsVisible ? 'Hide ' : 'View ') + | ||
| COPY.TASK_SNAPSHOT_TASK_INSTRUCTIONS_LABEL} | ||
| onClick={this.toggleTaskInstructionsVisibility} /> | ||
| { this.state.taskInstructionsIsVisible && |
There was a problem hiding this comment.
Let's put the "Show/hide task instructions" link text below the task instructions if the instructions are visible to match the mocks.
|
While we're in here messing with the |
lowellrex
reviewed
Dec 28, 2018
client/app/queue/TaskSnapshot.jsx
Outdated
| linkStyling | ||
| styling={css({ padding: '0' })} | ||
| name={(this.state.taskInstructionsIsVisible ? 'Hide ' : 'View ') + | ||
| COPY.TASK_SNAPSHOT_TASK_INSTRUCTIONS_LABEL} |
There was a problem hiding this comment.
Let's just make this two separate pieces of new copy in COPY.json instead of concatenating "Hide" and "View" every time.
lowellrex
reviewed
Dec 28, 2018
client/COPY.json
Outdated
| @@ -51,6 +51,9 @@ | |||
| "TASK_SNAPSHOT_TASK_TYPE_LABEL": "Task", | |||
| "TASK_SNAPSHOT_TASK_FROM_LABEL": "Assigned by", | |||
| "TASK_SNAPSHOT_TASK_INSTRUCTIONS_LABEL": "Task instructions", | |||
| "TASK_SNAPSHOT_VIEW_TASK_INSTRUCTIONS_LABEL": "View Task instructions", | |||
| "TASK_SNAPSHOT_HIDE_TASK_INSTRUCTIONS_LABEL": "Hide Task instructions", | |||
There was a problem hiding this comment.
Let's lowercase "Task" to match the mocks.
lowellrex
reviewed
Dec 28, 2018
spec/feature/queue/ama_queue_spec.rb
Outdated
| @@ -257,6 +257,7 @@ | |||
|
|
|||
| click_on "Pal Smith" | |||
|
|
|||
| find("button", text: "View " + COPY::TASK_SNAPSHOT_TASK_INSTRUCTIONS_LABEL).click | |||
There was a problem hiding this comment.
Let's update the tests to use the new copy we just added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8217 - Add link/button to show/hide task instructions