Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO-NOT-MERGE] This is only a test #23423

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DO-NOT-MERGE] This is only a test #23423

wants to merge 3 commits into from

Conversation

jcroteau
Copy link
Contributor

@jcroteau jcroteau commented Nov 4, 2024

[DO-NOT-MERGE] This is only a test

@jcroteau jcroteau added the Team: Hypernova A development team under the IT Modernization ART label Nov 4, 2024
@jcroteau
Copy link
Contributor Author

jcroteau commented Nov 4, 2024

test

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 4, 2024 •
edited
Loading

Code Climate has analyzed commit 5315b10 and detected 0 issues on this pull request.

View more on Code Climate.

@AKeyframe
Copy link
Contributor

I sure can, let me know if you need anything else with this.

@jcroteau jcroteau marked this pull request as ready for review November 4, 2024 22:40
@jcroteau
Copy link
Contributor Author

jcroteau commented Nov 4, 2024

test

1 similar comment
@jcroteau
Copy link
Contributor Author

jcroteau commented Nov 4, 2024

test

@jcroteau
Copy link
Contributor Author

jcroteau commented Nov 4, 2024

@jcroteau test

@jcroteau
Copy link
Contributor Author

jcroteau commented Nov 4, 2024

test

jcroteau
jcroteau commented Nov 4, 2024
View reviewed changes
Copy link
Contributor Author

@jcroteau jcroteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test review comment from self

@jcroteau jcroteau marked this pull request as draft November 4, 2024 23:02
@jcroteau jcroteau marked this pull request as ready for review November 4, 2024 23:02
jcroteau
jcroteau commented Nov 4, 2024
View reviewed changes
app/models/board_grant_effectuation.rb
@@ -14,7 +14,7 @@ class BoardGrantEffectuation < CaseflowRecord
belongs_to :end_product_establishment

validates :granted_decision_issue, presence: true
before_save :hydrate_from_granted_decision_issue, on: :create
before_save :hydrate_from_granted_decision_issue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add single comment on diff from self

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A review from self

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet another test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcroteau test

@AKeyframe
Copy link
Contributor

Another comment for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKeyframe AKeyframe Awaiting requested review from AKeyframe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Team: Hypernova A development team under the IT Modernization ART
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcroteau @AKeyframe