Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml #20329

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

craigrva
Copy link
Contributor

@craigrva craigrva commented Dec 22, 2023

Description

  • Adds KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true to the .workflow.yml file for Github Actions to enable re-running individual CI nodes in GHA jobs.
  • Updates config option in spec_helper.rb due to the previous config option being deprecated and causing Knapsack Pro problems

Acceptance Criteria

  • Code compiles correctly
  • Individual CI nodes can be re-run via Github Actions and correctly run the Rspec tests from that node.

Testing

  • Go to Actions run for this PR (Click checks above, then click on "Rspec Jest Lint Workflow")
  • In the top right of the page, find the button which says "Latest 2"
  • Click that button, then open "Attempt 1" in a new tab
  • Compare the failing nodes on Attempt 1 with those in Latest 2 and verify that the same number of tests were run on each node of Attempt 1 and Latest 2
  • If desired, click "Re-run Jobs" and then click "Re-run failing jobs". This will re-run the failing nodes and you when finished, you can verify the same data in the above step for each of the attempts that has been made

Copy link

codeclimate bot commented Dec 22, 2023

Code Climate has analyzed commit ea8b535 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@ajspotts ajspotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@craigrva craigrva merged commit 97149ba into master Dec 22, 2023
11 of 15 checks passed
@craigrva craigrva deleted the dev-support/enable-knapsack-fixed-queue-split branch December 22, 2023 21:04
jimfoley25 added a commit that referenced this pull request Dec 26, 2023
* Initial Commit

* Running tests

* Adding appellant phone number to serializer

* Adding paper case attribute

* Add attributes to search hash

* add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml (#20329)

* add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml

* update deprecated method for knapsack

* add comment

---------

Co-authored-by: AimanK <[email protected]>
Co-authored-by: raymond-hughes <[email protected]>
Co-authored-by: Craig Reese <[email protected]>
Co-authored-by: Raymond Hughes <[email protected]>
craigrva added a commit that referenced this pull request Jan 24, 2024
* Initial Commit

* Running tests

* Adding appellant phone number to serializer

* Adding paper case attribute

* Add attributes to search hash

* add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml (#20329)

* add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml

* update deprecated method for knapsack

* add comment

---------

Co-authored-by: AimanK <[email protected]>
Co-authored-by: raymond-hughes <[email protected]>
Co-authored-by: Craig Reese <[email protected]>
Co-authored-by: Raymond Hughes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants