Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASEFLOW-138 Propagate task instructions when task is bulk assigned #15899

Merged
merged 5 commits into from
Feb 17, 2021

Conversation

yoomlam
Copy link
Contributor

@yoomlam yoomlam commented Feb 10, 2021

Resolves CASEFLOW-138

Description

Propagate task instructions when task is bulk assigned

Acceptance Criteria

  • Task Instructions Remain When Task is Bulk Assigned

Testing Plan

(See Testing Plan in #15125. Borrowed from Testing Plan in #14523, except include instructions and check for instructions in newly assigned tasks.)

  1. Make Jolly Postman an admin
    OrganizationsUser.make_user_admin(User.find_by(css_id: "JOLLY_POSTMAN"), MailTeam.singleton)
  2. Log in as jolly postman and go to the mail team queue
  3. Go to Case Details for one of the Unassigned cases and grab the UUID from the URL
  4. Add instructions to the active task of the selected appeal:
t=Task.find(NNN)
t.update(instructions: ["do good"])
  1. Refresh Case Details and click View Instructions to see the instruction.
  2. Back in the queue view, click "Assign tasks"
  3. Assign some tasks to a user. Set the filters so that the case you modified will be bulk assigned.
  4. Confirm tasks were assigned to the user. See the Assigned tab.
  5. Open the appeal you modified to ensure the instructions propagated to the new user-task. Check the task instructions in the task tree:
t.children.active.first.instructions

Perform the same Testing Plan in the master branch and check that instructions are not propagated.

User Facing Changes

BEFORE AFTER
image image

@yoomlam yoomlam self-assigned this Feb 10, 2021
@codeclimate
Copy link

codeclimate bot commented Feb 10, 2021

Code Climate has analyzed commit ffc9c68 and detected 0 issues on this pull request.

View more on Code Climate.

@lomky lomky self-requested a review February 16, 2021 19:50
Copy link
Contributor

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lomky lomky added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Feb 17, 2021
@va-bot va-bot merged commit cf65c2a into master Feb 17, 2021
@va-bot va-bot deleted the yoom/138-bulk-assign-propagate-task-instructions branch February 17, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Echo 🐬
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants