Handle edge cases for EvidenceSubmissionWindowTasks #15598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hschallhorn
commented
Nov 10, 2020
| @@ -205,7 +206,7 @@ def expired_without_processing? | |||
| last_submitted = self[self.class.last_submitted_at_column] | |||
| return false unless last_submitted | |||
|
|
|||
| last_submitted < self.class.requires_processing_until | |||
| last_submitted < (self.class.requires_processing_until + self.class::EXPIRATION_WINDOW_BUFFER_HOURS.hours) | |||
There was a problem hiding this comment.
Called here:
ensures we catch any timers that will have slipped outside of this 4 day window by the time the next job is run
hschallhorn
commented
Nov 10, 2020
| # so they are not caught by the initial expired_without_processing? check when they are created. However, by the | ||
| # time the job has run, the task should have expired 4.000001 days ago and falls out of our | ||
| # expired_without_processing scope. See https://github.com/department-of-veterans-affairs/caseflow/issues/15245 | ||
| 4.days.ago + 30.minutes |
There was a problem hiding this comment.
weird time stuff math. + 30.minutes moves the completion time of this task to just under 4 days ago (3.979 days ago to be exact)
|
Code Climate has analyzed commit e50b415 and detected 0 issues on this pull request. View more on Code Climate. |
ajspotts
approved these changes
Nov 23, 2020
hschallhorn
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15245 and hopefully squash all those "incomplete and pending task timer" alerts
Description
The problem: Timers can be created with a date in the past, wild!
Current solution: Our "complete the timers" job that runs every hour will look for timers that should have been completed any time in the last four days!
"But what about timers that should have ended over four days ago?" you might ask: When we create a timer that should have been completed over 4 days ago, we immediately reset the timer to be picked up by the job on its next run!
"So what is the problem?" you may then ask: On occasion, timers are created that should have been completed 3.79 days ago, so they are not caught in the initial check. But by the time the job runs (could be up to an hour later), they are no longer inside of that 4 day window and are not completed by the job.
This PR adds a 1 hour buffer to that initial check so we take into account tasks that will slip out of the 4 day window by the next time the job is run.
Acceptance Criteria