Add SendCavcRemandProcessedLetterTask

[yoomlam]

Resolves #15076

Description

Add SendCavcRemandProcessedLetterTask when CavcTask is created.

Acceptance criteria

• This feature should be accessible to the following user groups: CAVC Litigation Support
• Consider better naming of SendCavcRemandProcessedLetterTask
  • couldn't think of anything better: SendCavcProcessedLetterTask, SendCavcCompleteLetterTask
• SendCavcRemandProcessedLetterTask is created on the new appeal stream as a child of the CAVC task
• SendCavcRemandProcessedLetterTask is assigned to the CAVC Litigation Support organization as unassigned
• The Actions drop-down has the following available for the Admin of the organization:
  • Assign to person
• Once assigned by the Admin of the organization, the Actions drop-down has the following available for the assigned user:
  • Add Admin Action Looks like we'll be removing this in Add Admin Actions to 'SendCavcRemandProcessedLetterTask' #15286, so leaving it out.
  • Mark task complete (Indicates letter has been sent to veteran)

I implemented task reassignment, but only for the user-task (task assigned to a user) not the org-task (task assigned to the CAVC Lit Support org). Reassignment of the org-task will cancel the existing org-task and create a user-task without an org-task parent, which is probably not what we want.

Testing Plan

1. Create the SendCavcRemandProcessedLetterTask task

# Find an appeal with an open DistributionTask to play with
appeal=DistributionTask.open.first.appeal
appeal.treee

distr_task=appeal.tasks.open.where(type: DistributionTask.name).first 
cavc_task=CavcTask.create(appeal: appeal, parent: distr_task)
appeal.reload.treee

send_task=SendCavcRemandProcessedLetterTask.create(appeal: appeal, parent: cavc_task)
appeal.reload.treee

1. Sign in as # CAVC_LIT_SUPPORT_ADMIN (VACO) and switch to their CAVC Lit Support team view. The appeal should be listed in the Unassigned tab.
2. Click on the case; assign task to a CAVC Lit Support team member; check that case is now under the "Assigned" tab.
3. Sign in as the user you assigned it to and go to their queue; click on the case.
4. Play around with task actions, check the case appears in correct queue tab, and check the task tree appeal.reload.treee
   • ADD_ADMIN_ACTION; cancel it (Task.where(id: [3374, 3375]).map(&:cancelled!)) or complete it as the assigned user to have the case assigned back to the assigner. Can also destroy the tasks (Task.where(id: [3374, 3375]).map(&:destroy)).
   • REASSIGN_TO_PERSON
   • MARK_COMPLETE will complete all the way up the tree up to (and including CavcTask since it has no open children tasks). Can test scenario where CavcTask does have other open children after marking the task complete.

                                                      ┌──────────────────────────────────────────────────────────────────────────────────────────────┐
Appeal 9 (evidence_submission) ────────────────────── │ ID   │ STATUS    │ ASGN_BY                │ ASGN_TO                │ UPDATED_AT              │
└── RootTask                                          │ 24   │ on_hold   │                        │ Bva                    │ 2020-11-03 21:30:55 UTC │
    └── DistributionTask                              │ 25   │ on_hold   │                        │ Bva                    │ 2020-11-03 21:30:55 UTC │
        ├── EvidenceSubmissionWindowTask              │ 26   │ assigned  │                        │ MailTeam               │ 2020-11-03 21:30:55 UTC │
        └── CavcTask                                  │ 3369 │ completed │                        │ Bva                    │ 2020-11-04 18:18:39 UTC │
            └── SendCavcRemandProcessedLetterTask     │ 3372 │ completed │                        │ CavcLitigationSupport  │ 2020-11-04 18:18:39 UTC │
                └── SendCavcRemandProcessedLetterTask │ 3373 │ completed │ CAVC_LIT_SUPPORT_ADMIN │ CAVC_LIT_SUPPORT_USER1 │ 2020-11-04 18:18:38 UTC │
                                                      └──────────────────────────────────────────────────────────────────────────────────────────────┘

User Facing Changes

• Screenshots of UI changes added to PR & Original Issue

BEFORE	AFTER
(None)	For CAVC Lit Support Admin user for an org-task
(None)	For CAVC Lit Support Non-Admin user for a user-task

Code Documentation Updates

• Add or update code comments at the top of the class, module, and/or component.

[codeclimate]

Code Climate has analyzed commit ab50611 and detected 0 issues on this pull request.

View more on Code Climate.

[yoomlam]

Stay in the "team cases" view after assigning a case.

[hschallhorn]

I wonder if a better play here would be to send the user back to the organization queue for all tasks that are assigned to an org

extras[:redirect_after] = "/organizations/#{task.assigned_to.url}" if task.assigned_to_type == Organization.name

Would cover both redirects for these special cases, but also provide redirecting that makes more sense when assigning any org task.
Thoughts? Out of scope of this pr?

[yoomlam]

Using your suggestion, 2 tests failed. I think a separate ticket is appropriate.

[hschallhorn]

Ran testing from a make reset. Kat added some seeds and, with your additions, we've got 9 open SendCavcRemandProcessedLetterTasks to play with!

[hschallhorn]

Checked bulk task assign as well! Looks great :trulyamazingpanda:

[yoomlam]

Check for expected parent task in these 3 tests as well.

[hschallhorn]

Looks great!