-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only send AttorneyTasks back to judge assign #15493
Conversation
def update_params_will_cancel_task?(params) | ||
params[:status].eql?(Constants.TASK_STATUSES.cancelled) | ||
def update_params_will_cancel_attorney_task?(params) | ||
type == AttorneyTask.name && params[:status].eql?(Constants.TASK_STATUSES.cancelled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change! Only AttyTasks go back to judge assign, not subclasses
@@ -416,7 +416,7 @@ def self.find_first_task_or_create(appeal, task_type) | |||
parent { create(:ama_judge_decision_review_task, appeal: appeal) } | |||
end | |||
|
|||
factory :ama_judge_dispatch_return_to_attorney_task, class: AttorneyDispatchReturnTask do | |||
factory :ama_attorney_dispatch_return_task, class: AttorneyDispatchReturnTask do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sneaky rename
it "calls send_back_to_judge_assign!" do | ||
tasks = attorney_task.update_from_params({ status: Constants.TASK_STATUSES.cancelled }, attorney) | ||
tasks = subject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Code Climate has analyzed commit 59cb904 and detected 0 issues on this pull request. View more on Code Climate. |
Resolves #15218
Description
Cancelling ONLY
AttorneyTask
s will send a case back to judge assign.Acceptance Criteria
AttorneyTask
subtypes return control to their parent, instead of cancelling them and creating aJudgeAssignTask
AttorneyTasks
cancel their parentJudgeDecisionReviewTask
and create aJudgeAssignTask
Testing Plan