Connect backend and frontend for convert hearing type page #15314

ferristseng · 2020-09-24T20:36:15Z

Resolves #15159

Description

Create HearingTypeConversion component which wraps the HearingTypeConversionForm
Create new route that's connected to the convert hearing type task action
Small refactors
- Made the logic to determine whether or not to display the veteran vs. appellant name consistent
- Attempt to consolidate where hearing request type mappings are defined in a single location

Acceptance Criteria

Selecting "Convert hearing type to virtual" on a ChangeHearingRequestTypeTask shows the non-modal "Convert Hearing to Virtual" form (created in Non-modal form for converting travel board request type to virtual #15217)
Submitting the "Convert hearing to virtual" form causes the new request type to be recorded correctly

The expected alert is shown when the conversion has successfully taken place

If the appeal has been geomatched:

The hearing request is in the scheduling queue for the [Regional office name] regional office.

If the appeal has not been geomatched:

The hearing request is in the scheduling queue for the appropriate regional office.

Testing Plan

N/A

User Facing Changes

Note: The task tree is a bit messed up because I was reusing the same appeal over and over again. When I completed the task the first time, it unlocks the schedule hearing task. From there, I was able to schedule the appeal, which is why you see the select hearing disposition task in the screencap.

Code Documentation Updates

Add or update code comments at the top of the class, module, and/or component.

Storybook Story

For Frontend (Presentationa) Components

Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
Give it a title that reflects the component's location within the overall Caseflow hierarchy
Write a separate story (within the same file) for each discrete variation of the component

va-bot · 2020-09-24T20:38:13Z

	2 Warnings
⚠️	This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews
⚠️	This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

codeclimate · 2020-09-24T20:41:14Z

Code Climate has analyzed commit 69926a5 and detected 0 issues on this pull request.

View more on Code Climate.

ferristseng · 2020-09-28T15:00:08Z

app/controllers/tasks_controller.rb

@@ -106,6 +106,8 @@ def update
    render json: {
      tasks: tasks_hash
    }
+  rescue ActiveRecord::RecordInvalid => error
+    invalid_record_error(error.record)


I was using this to test the error handling code on the frontend. I figured it probably makes sense to always JSONify any validation errors, so I kept it in the PR.

ferristseng · 2020-09-28T15:01:30Z

app/models/hearing_day.rb

-    travel: "T",
-    central: "C"
-  }.freeze
+  REQUEST_TYPES = Constants::HEARING_REQUEST_TYPES.with_indifferent_access.freeze


I moved these mappings to a JSON constants file so the frontend would have access to them too.

ferristseng · 2020-09-28T15:03:21Z

client/app/hearings/components/VirtualHearings/AppellantSection.jsx

-
+  // Depending on where this component is used, the *FullName fields will be available.
+  // If they aren't, the *FirstName/*LastName fields should be available.
+  const appellantName = hearing?.appellantIsNotVeteran ?


I made this based on the appellantIsNotVeteran flag, which is how we determine whether or not to use appellant vs. veteran in other places.

Thanks thats a much better way to check

ferristseng · 2020-09-28T15:04:33Z

client/app/hearings/constants.js

@@ -126,9 +126,3 @@ export const HEARING_CONVERSION_TYPES = [
  'change_email_or_timezone',
  'change_hearing_time'
 ];
-
-export const HEARING_REQUEST_TYPES = {


I removed this and preferred directly importing VIDEO_HEARING, CENTRAL_OFFICE_HEARING, and VIRTUAL_HEARING. We declare these kinds of mappings in a bunch of different places, so I'm trying to consolidate where possible.

sahalliburton

LGTM, I tested both scenarios and when geomatched it does show the regional office and when not it shows the correct text. There is just one issue I noticed and that is when the hearing is converted to travel, I need to refresh the page in order to see the hearing type change to "Virtual"

ferristseng · 2020-09-29T22:18:21Z

There is just one issue I noticed and that is when the hearing is converted to travel, I need to refresh the page in order to see the hearing type change to "Virtual"

It looks like this is an issue because the appeal never gets refreshed after the change is made. I updated the submit call to delete the appeal from the store, which forces the case details page to do a full reload of the appeals data.

Commit: 2ac01b3

sahalliburton

LGTM

Resolves [CASEFLOW-210](https://vajira.max.gov/browse/CASEFLOW-210) ### Description Gives Hearing Coordinators the ability to convert the hearing request type on any appeal applying the same workflow as was used to convert Travel Board request types implemented in #15314. ### Acceptance Criteria - [ ] Code compiles correctly - [ ] Users are able to successfully convert hearing request types from Central Office/Video to Virtual ### Testing Plan 1. Shadow user `BVASYELOW`: http://localhost:3000/test/users 2. Navigate to the hearing schedule: http://localhost:3000/hearings/schedule 3. Click the "Schedule Veterans" button 4. Search for "St. Petersburg, FL" in the Regional Office dropdown and navigate to the "AMA Veterans Waiting" tab 5. Select 1 of the Veterans from the list to navigate to their case details page 6. Once the case details page loads, check the actions dropdown for the Convert to Virtual Hearing action and select that 7. Review the conversion page and based on whether you selected the Central Office or another regional office, you should see a message at the top indicating in which queue this request will be 8. Click the Convert to Virtual Hearing button 9. Ensure you receive a success banner and that the action to Convert to Virtual Hearing is no longer available 10. Ensure that the Hearing Request type in the claims header now says Virtual 11. Scroll down and check that there is a ChangeHearingRequestType indicating the conversion 12. Scroll back up and click the Schedule Veteran action and ensure that the Virtual option is preselected ### Code Documentation Updates - [x] Add or update code comments at the top of the class, module, and/or component. ### Database Changes *Only for Schema Changes* * [x] Column comments updated * [x] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [x] DB schema docs updated with `make docs` (after running `make migrate`) * [x] #appeals-schema notified with summary and link to this PR

ferristseng added the Team: Tango 💃 label Sep 25, 2020

ferristseng requested review from a team, rubaiyat22 and sahalliburton and removed request for a team and rubaiyat22 September 28, 2020 14:59

ferristseng commented Sep 28, 2020

View reviewed changes

sahalliburton suggested changes Sep 29, 2020

View reviewed changes

ferristseng added 17 commits September 29, 2020 17:54

add page route for the change hearing request type page

fb865af

consolidate HEARING_REQUEST_TYPES definitions

9b019d2

linter changes

9c599ce

initial work to connect backand end frontend

74c2590

create new component to initialize HearingTypeConversionForm

4f9bd2d

Add success messaging to COPY

6d1274d

commit new component

6941913

use new COPY constant

01ab73d

update success message formatting

0a3d39d

use constants

0e86865

addressing some lint warnings

987f8bc

fixing tests

5f6e0f3

updated snapshot

8975785

reordering when the success message gets shown

966fc31

add simple story for the ToVirtual workflow

e635156

create feature test for working a change hearing request type task

627277d

fix logic around displaying the appellant/veteran name

1b7b788

ferristseng added 7 commits September 29, 2020 17:54

add jest test for HearingTypeConversion component

33e7713

format ActiveRecord::RecordInvalid for task updates

64111af

render server error message

7a15c3f

fixing linting issues

832fcf1

updating test snapshots

0544c47

updating appellant/veteran naming logic

075c852

force a reload for the appeal data when the task is updated

2ac01b3

ferristseng force-pushed the ftseng/15159-connect-travel-board-page branch from 530f91b to 2ac01b3 Compare September 29, 2020 22:15

update snapshot

eb8f524

sahalliburton approved these changes Sep 30, 2020

View reviewed changes

ferristseng added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Sep 30, 2020

Merge branch 'master' into ftseng/15159-connect-travel-board-page

69926a5

va-bot merged commit 89c7ca7 into master Sep 30, 2020

va-bot deleted the ftseng/15159-connect-travel-board-page branch September 30, 2020 15:15

sahalliburton mentioned this pull request Jan 20, 2021

Added convert to virtual for video hearings #15805

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connect backend and frontend for convert hearing type page #15314

Connect backend and frontend for convert hearing type page #15314

ferristseng commented Sep 24, 2020 •

edited

Loading

va-bot commented Sep 24, 2020 •

edited

Loading

codeclimate bot commented Sep 24, 2020 •

edited

Loading

ferristseng Sep 28, 2020 •

edited

Loading

ferristseng Sep 28, 2020

ferristseng Sep 28, 2020

sahalliburton Sep 29, 2020

ferristseng Sep 28, 2020

sahalliburton left a comment

ferristseng commented Sep 29, 2020 •

edited

Loading

sahalliburton left a comment

Connect backend and frontend for convert hearing type page #15314

Connect backend and frontend for convert hearing type page #15314

Conversation

ferristseng commented Sep 24, 2020 • edited Loading

Description

Acceptance Criteria

Testing Plan

User Facing Changes

Code Documentation Updates

Storybook Story

va-bot commented Sep 24, 2020 • edited Loading

codeclimate bot commented Sep 24, 2020 • edited Loading

ferristseng Sep 28, 2020 • edited Loading

Choose a reason for hiding this comment

ferristseng Sep 28, 2020

Choose a reason for hiding this comment

ferristseng Sep 28, 2020

Choose a reason for hiding this comment

sahalliburton Sep 29, 2020

Choose a reason for hiding this comment

ferristseng Sep 28, 2020

Choose a reason for hiding this comment

sahalliburton left a comment

Choose a reason for hiding this comment

ferristseng commented Sep 29, 2020 • edited Loading

sahalliburton left a comment

Choose a reason for hiding this comment

ferristseng commented Sep 24, 2020 •

edited

Loading

va-bot commented Sep 24, 2020 •

edited

Loading

codeclimate bot commented Sep 24, 2020 •

edited

Loading

ferristseng Sep 28, 2020 •

edited

Loading

ferristseng commented Sep 29, 2020 •

edited

Loading