[Part 4] Create non default distribution seed data

[hschallhorn]

bumps #14604

Part 1: #14745
Part 2: #14715
Part 3: #14761

Description

Add an easy way to test this job

Acceptance Criteria

• Can generate seed data to test distributions
• Distribution job performs as expected

Testing Plan

1. Run the new/fixed seeds

make reset

1. Generate some data!!!

# Fix some bad dev data
VACOLS::Staff.find_by(sdomainid: "BVARERDMAN").update!(svlj: "J")
CacheManager.new.clear(:vacols)
# Going to create a lot of data here, better set up some stuff for versions
RequestStore[:current_user] = User.system_user
# Because db/seeds is not in the autoload path, we must load them explicitly here
Dir[Rails.root.join("db/seeds/*.rb")].sort.each { |f| require f }
# Seed away!!!!
Seeds::PriorityDistributions.new.seed!
# Note the bfkey of the last distributed case printed out from the job
failed_distribution_case_id = DistributedCase.last.case_id

2. Check out some of the job methods!

job = PushPriorityAppealsToJudgesJob.new
# Let's distribute cases tied to our elligible judges
tied_distributions = job.distribute_non_genpop_priority_appeals
# How many did each of them get?
tied_distributions.map { |dist| [dist.judge_id, dist.statistics["batch_size"]] }.to_h
=> {3=>3, 64=>1, 5=>0, 4=>3, 73=>2}

# Let's calculate our priority target!
# Let's looks at how many priority cases have bee distributed this month for each of our judges
job.eligible_judge_priority_distributions_this_month
=> {3=>18, 64=>13, 5=>9, 4=>7, 73=>17}
# How many priority cases are ready to be distributed?
job.ready_priority_appeals_count
=> 122
# How many of each?
docket_coordinator = DocketCoordinator.new
docket_coordinator.dockets.map do |docket_type, docket|
   [docket_type, docket.ready_priority_appeal_ids.count]
 end.to_h
=> {:legacy=>42, :direct_review=>68, :evidence_submission=>4, :hearing=>8}
# What should we aim for for each judge to be the most "fair"
job.priority_target
=> 37
# How many cases does that translate to to distribute to each judge now?
job.eligible_judge_target_distributions
=> {3=>19, 64=>24, 5=>28, 4=>30, 73=>20}
# Does the priority target leave any leftover cases that need distributing?
job.leftover_cases_count
=> 1
#Let's dish that one case out to whoever has the least number of cases
job.eligible_judge_target_distributions_with_leftovers
=> {3=>20, 73=>20, 64=>24, 5=>28, 4=>30}

# Anndddddd distribute!
genpop_distributions = job.distribute_genpop_priority_appeals
genpop_distributions.map { |dist| [dist.judge_id, dist.statistics["batch_size"]] }.to_h
# How'd we do??
=> {3=>19, 73=>20, 64=>24, 5=>28, 4=>22}
# Looks like we're missing some
job.instance_variable_set(:@tied_distributions, tied_distributions)
job.instance_variable_set(:@genpop_distributions, genpop_distributions)
puts job.slack_report.join("\n")

[WARN]
*Number of cases tied to judges distributed*: 9
*Number of general population cases distributed*: 113
*Age of oldest legacy case*: 0 days
*Age of oldest direct_review case*: 0 days
*Age of oldest evidence_submission case*: 0 days
*Age of oldest hearing case*: 0 days
*Number of appeals _not_ distributed*: 8

*Debugging information*
Priority Target: 37
Previous monthly distributions: {3=>37, 64=>37, 5=>37, 4=>29, 73=>37}
Legacy appeals not distributed: `LegacyAppeal.where(vacols_id: ["3429072462", "2181906143"])`
AMA appeals not distributed: `Appeal.where(uuid: ["3788816f-5de9-4727-b5ea-09c0868e2435", "22800998-59e0-4a8e-9477-bf5772e1526d", "3f9a7fc0-82a1-462d-934f-ab4c6fa92f14", "98c6227d-2ea5-4fe3-b8e3-b76fb9d462f8", "4fba02a7-760a-4f49-8242-291d3bd2b449", "164adfeb-b26d-4274-8331-12decce58051", "8a92e9c5-56e0-4515-aece-b2fb0b6d0433", "c3bb1ec9-77d2-45c7-b62a-424d2a304817"])`
Some cases are ready to distribute but could not be. This could be due to the tied judge being an acting judge or an attorney (`!user.judge_in_vacols?`). These will be handled manually by the board. The tied judge could also have priority distribution turned off and should not be pushed cases (`JudgeTeam.for_judge(user).accepts_priority_pushed_cases?`). There could also be a duplicate distributed case blocking distribution (`DistributedCase.find_by(case_id: case_id`) or our validations for redistributing legacy appeals failed (https://github.com/department-of-veterans-affairs/caseflow/blob/master/app/services/redistributed_case.rb#L26)

appeals = Appeal.where(uuid: ["3788816f-5de9-4727-b5ea-09c0868e2435", "22800998-59e0-4a8e-9477-bf5772e1526d", "3f9a7fc0-82a1-462d-934f-ab4c6fa92f14", "98c6227d-2ea5-4fe3-b8e3-b76fb9d462f8", "4fba02a7-760a-4f49-8242-291d3bd2b449", "164adfeb-b26d-4274-8331-12decce58051", "8a92e9c5-56e0-4515-aece-b2fb0b6d0433", "c3bb1ec9-77d2-45c7-b62a-424d2a304817"])
# Let's check out who these cases are tied to
judge_ids = appeals.map(&:hearings).flatten.map(&:judge_id).uniq
judge_ids.map { | id| JudgeTeam.for_judge(User.find(id))&.accepts_priority_pushed_cases? }
=> [nil, nil, false]
# These are all cases tied to judges that either do not have a judge team or do not have a judge team with priority push on!

# How about our legacy appeals?
VACOLS::CaseDocket.connection.exec_query(VACOLS::CaseDocket::SELECT_PRIORITY_APPEALS).to_hash
=> [{"bfkey"=>"3429072462", "bfdloout"=>2020-08-04 00:00:00 UTC, "vlj"=>"15"},
    {"bfkey"=>"2181906143", "bfdloout"=>2020-08-04 00:00:00 UTC, "vlj"=>"5"}]
JudgeTeam.where(name: VACOLS::Staff.where(sattyid: "15").pluck(:sdomainid))
=> []
# The case is tied to a judge that does not have a judge team
JudgeTeam.where(name: VACOLS::Staff.where(sattyid: "5").pluck(:sdomainid))
=> [#<JudgeTeam:0x00007fa3ebcfb2c8
  id: 24,
  accepts_priority_pushed_cases: false,
  ... >]
# The case is tied to a judge that does not have a judge team that accepts pushed cases

# Ensure the already distributed case was not sent to a judge
LegacyAppeal.find_by(vacols_id: failed_distribution_case_id).location_code
=> "CASEFLOW"

3. Reseed and run the job standalone

make reset

VACOLS::Staff.find_by(sdomainid: "BVARERDMAN").update!(svlj: "J")
CacheManager.new.clear(:vacols)
RequestStore[:current_user] = User.system_user
Dir[Rails.root.join("db/seeds/*.rb")].sort.each { |f| require f }
Seeds::PriorityDistributions.new.seed!
failed_distribution_case_id = DistributedCase.last.case_id
job = PushPriorityAppealsToJudgesJob.new
ActiveRecord::Base.multi_transaction do
  job.perform_now
rescue => e
  Rails.logger.error(e.message)
  Rails.logger.error(e.backtrace.join("\n"))
end
puts job.slack_report.join("\n")

[codeclimate]

The SHA range provided is invalid

View more on Code Climate.

[va-bot]

	1 Warning
⚠️	This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews

Generated by 🚫 Danger

[lomky]

Back to you with some questions and suggestions!

[lomky]

Suggestion: Since we're not invoking this by default, what do you think about adding a make command to do this? something like make seed-distribution so we don't lose track of this

[lomky]

😲 😍 🎉

[lomky]

🍳 🙆

[lomky]

GTG once the specs pass! 🌱 😻