Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round Robin Data Collection #14768

Closed
wants to merge 1 commit into from
Closed

Round Robin Data Collection #14768

wants to merge 1 commit into from

Conversation

lomky
Copy link
Contributor

@lomky lomky commented Jul 24, 2020

Resolves #14629

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to ...

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Storybook Story

For Frontend (Presentationa) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Database Changes

Only for Schema Changes

  • Timestamps (created_at, updated_at) for new tables
  • Column comments updated
  • Verify that migrate:rollback works as desired (change supported functions)
  • Query profiling performed (eyeball Rails log, check bullet and fasterer output)
  • Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • DB schema docs updated with make docs (after running make migrate)
  • #appeals-schema notified with summary and link to this PR

@codeclimate
Copy link

codeclimate bot commented Jul 24, 2020

Code Climate has analyzed commit 73ecd04 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Style 1

View more on Code Climate.

@lomky lomky self-assigned this Jul 27, 2020
@lomky
Copy link
Contributor Author

lomky commented Aug 10, 2020

Defunct - issue identified by @yoomlam in #14629 (comment)

@lomky lomky closed this Aug 10, 2020
@alisan16 alisan16 deleted the kat/14629_round_robin_info branch December 14, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify problem with or collect information on RoundRobin Automatic Task Assignments
1 participant