-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 2] Populate aod_based_on_age column #14764
[Part 2] Populate aod_based_on_age column #14764
Conversation
Code Climate has analyzed commit 26120303 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial feedback before testing!
b62cc20
to
3264d8d
Compare
expect(claimant.advanced_on_docket?(1.year.ago)).to eq(true) | ||
expect(claimant.advanced_on_docket_motion_granted?(1.year.ago)).to eq(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a quick expect(claimant.advanced_on_docket_based_on_age?).to eq(false)
check here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional AC:
-
a.advanced_on_docket?
doesn't make any database requests to other tables if the vet is aod based on age once age_aod is set! ⏩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!! Glad we found a simpler way to implement this! Nice work!
* add aod_based_on_age column to appeals * [Part 2] Populate age_aod column (#14764) * add and use conditionally_set_aod_based_on_age * add SetAppealAgeAodJob * enable finer access to reasons for AOD * exclude AttorneyClaimant from AOD logic * improve test coverage * handle case where aod_based_on_age changes to false
Resolves #14637
Part 1
Description
Only for AMA appeals -- AOD status of legacy appeals can be found in VACOLS.
Add and use
Appeal.conditionally_set_aod_based_on_age
method to set the newaod_based_on_age
table column when loaded by the user.Add a job to set
aod_based_on_age
nightly for claimants who meet the age criteria.Acceptance Criteria
aod_based_on_age
is true, the appeal should show the AOD label/badge in the UI.aod_based_on_age
is true whenappeal.claimant.advanced_on_docket_based_on_age?
is true, afterappeal.advanced_on_docket?
is called.aod_based_on_age
is true).Testing Plan
rails db:migrate
aod_based_on_age
before and after changing things that would affect (and not affect)aod_based_on_age
(also check the UI for an AOD label):Remember to
rake db:rollback
when done.Code Documentation Updates