Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appeal.undecided_issues.count for legacy appeals #14746

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Use appeal.undecided_issues.count for legacy appeals #14746

merged 3 commits into from
Jul 22, 2020

Conversation

hschallhorn
Copy link
Contributor

@hschallhorn hschallhorn commented Jul 22, 2020 •
edited by ajspotts
Loading

Resolves bug detailed here

Description

Fixes bug based on investigation here

Acceptance Criteria

  • Number of issues for legacy appeals is correct in queue
    • on initial load
    • after filtering

Testing Plan

  1. Log in a steve casper
  2. Ensure user pagination is on 
    FeatureToggle.enabled?(:user_queue_pagination, user: User.first)
=> true
  3. Go to http://localhost:3000/queue?tab=on_hold_person and confirm legacy case issue counts are not all "1"
  4. Filter by legacy docket and confirm the same as well

User Facing Changes

  • issue counts in queue are correct for legacy appeals rather than just "1"
BEFORE AFTER
Screen Shot 2020-07-22 at 3 14 39 PM Screen Shot 2020-07-22 at 3 27 21 PM
Screen Shot 2020-07-22 at 3 32 33 PM Screen Shot 2020-07-22 at 3 25 02 PM

@hschallhorn hschallhorn self-assigned this Jul 22, 2020
@hschallhorn
Copy link
Contributor Author

Confused as to why we use multiple serializers?? Me too! #14291

@codeclimate
Copy link

codeclimate bot commented Jul 22, 2020 •
edited
Loading

Code Climate has analyzed commit 8c19e57 and detected 0 issues on this pull request.

View more on Code Climate.

ajspotts
ajspotts approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@ajspotts ajspotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hschallhorn hschallhorn added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jul 22, 2020
@va-bot va-bot merged commit 64899fb into master Jul 22, 2020
@va-bot va-bot deleted the hschallhorn/legacy-issue-count-fix branch July 22, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajspotts ajspotts ajspotts approved these changes

Assignees

@hschallhorn hschallhorn

Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hschallhorn @ajspotts @va-bot