Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convert central to virtual and virtual to central hearings workflow #14704
Add convert central to virtual and virtual to central hearings workflow #14704
Changes from 23 commits
ae5985f
05bca62
46d4cab
ffd7903
56d5d5c
6c18c47
70d961c
b28c8c6
0dc0fa7
3e9caa8
e3a789b
213ac24
19a2a24
338ec09
d5d0a72
b2203c5
18f9f81
e4bb04b
da4e49b
2e4ccb1
ea26986
3479701
4cb8f80
d360cff
461edad
76c861f
c9472c7
92de6af
29169f0
5cb406e
36a0534
d10e7e4
6f594b5
8150c92
8be58dc
aba96ec
f7dcbbe
a824725
a91e115
c904d26
2b756c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns that this may affect the performance of
DailyDocket
as thequick_to_hash
does not serialize things thatDailyDocket
does not need yet likeappellant_email_address
which make calls VACOLScc: @ferristseng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there will be a performance tradeoff whether we use the quick_to_hash here or make an additional call on the details page, this preloads data that will be needed to reduce the number of roundtrips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up reverting this and removing the frontend caching for now as it was creating too much of a bottleneck on the daily docket page @rubaiyat22 and @ferristseng, we should create a separate ticket though to revisit frontend caching so that we can improve client-side performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the forms context into the DetailsContainer component to inherit state that we already have