Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shalliburton/fix saving hearing time #14539

Merged
merged 17 commits into from
Jun 16, 2020

Conversation

sahalliburton
Copy link
Contributor

Description

Updates the way that hearings are being sorted, previously was happening on every render and this changes to sort only on first render

Acceptance Criteria

  • Code compiles correctly

@sahalliburton sahalliburton requested review from ferristseng, rubaiyat22 and tomas-nava and removed request for ferristseng June 16, 2020 17:17
@va-bot
Copy link
Collaborator

va-bot commented Jun 16, 2020

1 Warning
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Jun 16, 2020

Code Climate has analyzed commit c2a733b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@tomas-nava tomas-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 approve!

@tomas-nava tomas-nava added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jun 16, 2020
@sahalliburton sahalliburton removed the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jun 16, 2020
@sahalliburton sahalliburton added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jun 16, 2020
@tomas-nava tomas-nava merged commit eb8cf71 into master Jun 16, 2020
@alisan16 alisan16 deleted the shalliburton/fix-saving-hearing-time branch December 14, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants