Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Updates to AddClaimantModal (#14202)"" #14484

Conversation

jcq
Copy link
Contributor

@jcq jcq commented Jun 8, 2020

(Connects #14153)

Reverts #14434, which reverted #14202.

We reverted #14202 due to issues with builds failing in production. We have since changed things at the devops level, and we want to get this code merged in.

@va-bot
Copy link
Collaborator

va-bot commented Jun 8, 2020

2 Warnings
⚠️ This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2020

Code Climate has analyzed commit c3eac3f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

JC Quirin added 3 commits June 8, 2020 10:10
Copy link
Contributor

@leikkisa leikkisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this is fixed now!
🤞 😉

@jcq jcq added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jun 8, 2020
@va-bot va-bot merged commit 995a2f8 into master Jun 8, 2020
@va-bot va-bot deleted the revert-14434-pek-revert-9b70c85121029398ba16ea26588d56cd34c3b66b branch June 8, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Foxtrot 🦊
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants