Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Debounce in AddClaimantModal #14454

Merged
merged 52 commits into from
Jun 8, 2020
Merged

Fixed Debounce in AddClaimantModal #14454

merged 52 commits into from
Jun 8, 2020

Conversation

jcq
Copy link
Contributor

@jcq jcq commented Jun 2, 2020 •
edited
Loading

Connects #14430

Description

Fixes regression from #14202; this brings fully functioning debounce functionality in AddClaimantModal along with additional JS tests

Acceptance Criteria

  • Code compiles correctly
  • API calls are properly debounced in AddClaimantModal

JC Quirin and others added 30 commits May 1, 2020 14:40
Updated copy in label for LIT_SUPPORT_PULAC_CERULLO task action
31ef0e2
Updated the url used for the Notify Lit Support modal
64c9cd9 
(removes mention of Pulac Cerullo in URL)
Updated existing SelectClaimant component:
33646a1 
added proptypes;
refactored into functional component
added frontend support for attorney_fees feature toggle
4d359f6
added AddClaimantModal;
195c3c7 
added story for `AddClaimantModal`;
updated `SelectClaimant` to allow opening of `AddClaimantModal` if `attorneyFees` feature toggle is enabled;
linting
ea91c10
basics for onCancel and stub for onSubmit for AddClaimantModal from…
a1652fd 
… `SelectClaimant`
linting
3fa7d55
SelectClaimant only displays "Add Claimant" button if `veteranIsNot…
ef0af5e 
…Claimant` is true;
Merge branch 'master' into jc/14136-add-claimant-modal
3d4aea7
fixed PropTypes on SelectClaimant;
bacaf53 
added ADD_CLAIMANT_MODAL_TITLE to COPY
AddClaimantModal now pulls title from COPY;
bf0c125
Merge branch 'master' into jc/14136-add-claimant-modal
cd9288e
wired up missing closeHandler on AddClaimantModal
508a021
Merge branch 'master' into jc/14136-add-claimant-modal
7911600
restructured sample data to make it clear AddClaimantModal is focus…
3763f24 
…ed on returning participantId
Added feature test to ensure "Add Claimant" option is available
da7f331 
(if appropriate feature toggle is set)
@jcq
Merge branch 'master' into jc/14136-add-claimant-modal
a522023
implemented debounce & async search to AddClaimantModal
5c99f45
SelectClaimant updates redux store w/ participant ID of added claimant
0328d07
Merge branch 'master' into jc/14153-update-add-claimant-modal
0784a4f
updated babel config for test environment
ab15ec1 
(avoids errors with async functions at top level of files)
Merge branch 'master' into jc/14153-update-add-claimant-modal
9b06090
Merge branch 'master' into jc/14153-update-add-claimant-modal
07dd21a
updated AddClaimantModal to fetch data from '/intake/attorneys' endpoint
31509fe 
(default — optionally supports a different async fn as a prop)
Merge branch 'master' into jc/14153-update-add-claimant-modal
538e2eb
built out ability to show and remove added attorney
d76212b
added faker.js
092c2ba
added "relationship to veteran" select to AddClaimantModal;
b96c295 
added basic local/mock data & async search fn in `AddClaimantModal` story;
Various updates to "Add Claimant" functionality, tests
8488b0f
JC Quirin and others added 16 commits May 21, 2020 14:37
added test for removing added claimant
bf0fe6e
Merge branch 'master' into jc/14153-update-add-claimant-modal
fefe61a
added @testing-library/react;
578a726 
added @testing-library/user-event;
set default relationship in AddClaimantModal
1b6c495
added jest tests & snapshots for AddClaimantModal
4a52534
Merge branch 'master' into jc/14153-update-add-claimant-modal
00a9cd8
linting
b463684
@jcq
Merge branch 'master' into jc/14153-update-add-claimant-modal
dcca175
moved "Add Claimant" tests from intake_spec to review_page_spec
8ca5460
updated SearchableDropdown to support:
37eb858 
- loading indicator
- filterOption fn
- filterOptions fn
(it passes relevant props to react-select)
updated AddClaimantModal to ensure claimant dropdown shows all opti…
4ac2108 
…ons returned from backend
linting
c63208d
Merge branch 'master' into jc/14153-update-add-claimant-modal
dc979e3
updated snapshot for AddClaimantModal
bfd59b6
Merge branch 'master' into jc/14153-update-add-claimant-modal
300f11f
fixed debounce functionality in AddClaimantModal;
778bc92 
additional jest tests for `AddClaimantModal`;
@va-bot
Copy link
Collaborator

va-bot commented Jun 2, 2020 •
edited
Loading

1 Warning
⚠️ This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Jun 2, 2020 •
edited
Loading

Code Climate has analyzed commit a86b33c and detected 0 issues on this pull request.

View more on Code Climate.

leikkisa
leikkisa reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@leikkisa leikkisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure if I completely understand the behavior that was happening with the bug, I added a comment to the test. I think it'll make sense for Yang to check this out too since he's more familiar, but so far looks good to me.

client/app/intake/components/SelectClaimant.jsx Outdated Show resolved Hide resolved
client/test/app/intake/components/AddClaimantModal.test.js Show resolved Hide resolved
client/app/intake/components/AddClaimantModal.jsx Show resolved Hide resolved
client/app/intake/components/AddClaimantModal.jsx Show resolved Hide resolved
nanotone
nanotone approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@nanotone nanotone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the debounce test, but after that I'd say this is 👍 to go!

TIL that debounce comes with lodash, and leading vs trailing edges.

@jcq jcq added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jun 8, 2020
@va-bot va-bot merged commit e94dc74 into master Jun 8, 2020
@va-bot va-bot deleted the jc/14153-fix-debounce branch June 8, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leikkisa leikkisa leikkisa left review comments

@nanotone nanotone nanotone approved these changes

Assignees
No one assigned
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Foxtrot 🦊
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcq @va-bot @nanotone @leikkisa