Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overtime status on case reassign #14446

Closed
wants to merge 4 commits into from

Conversation

hschallhorn
Copy link
Contributor

Resolves #14366

Description

Removes the overtime status of appeal when an appeal is reassigned.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to ...

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Storybook Story

For Frontend (Presentationa) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Database Changes

Only for Schema Changes

  • Timestamps (created_at, updated_at) for new tables
  • Column comments updated
  • Query profiling performed (eyeball Rails log, check bullet and fasterer output)
  • Appropriate indexes added (especially for foreign keys, polymorphic columns, and unique constraints)
  • DB schema docs updated with make docs
  • #appeals-schema notified with summary and link to this PR

@hschallhorn hschallhorn self-assigned this Jun 2, 2020
@codeclimate
Copy link

codeclimate bot commented Jun 2, 2020

Code Climate has analyzed commit d9ec09a and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 3

View more on Code Climate.

@hschallhorn
Copy link
Contributor Author

Stacking!

@hschallhorn hschallhorn closed this Jun 2, 2020
@hschallhorn hschallhorn deleted the hschallhorn/14366-remove-ot-on-reassign branch June 4, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OT status for cases that are reassigned
1 participant