fall back to created_at/now if no from_date is set in EvidenceSubmissionWindowTask #14204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check for evidence submission docket case first - fall back to created_at/now so from_date is never nil - alert sentry if from_date's nil and there's no schedule hearing task child of the parent task - update the test for no schedule hearing task case - move a test inside the 'appeal is in the hearing docket' context because it was failing after reordering checks in timer_ends_at
| private | ||
|
|
||
| def set_assignee | ||
| self.assigned_to ||= MailTeam.singleton | ||
| end | ||
|
|
||
| def ensure_from_date_set(from_date) | ||
| if from_date.blank? && open_schedule_hearing_task.blank? | ||
| msg = "EvidenceSubmissionWindowTask #{id} on Appeal #{appeal.id} was unable to calculate " \ |
There was a problem hiding this comment.
This is a much better error message, I will try to be more detailed like this going forward. Thanks!
sahalliburton
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #14077
Follows #14135
child of the parent task
because it was failing after reordering checks in timer_ends_at