Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated copy in label for LIT_SUPPORT_PULAC_CERULLO task action #14162

Merged
merged 2 commits into from
May 2, 2020
Merged

Updated copy in label for LIT_SUPPORT_PULAC_CERULLO task action #14162

merged 2 commits into from
May 2, 2020

Conversation

jcq
Copy link
Contributor

@jcq jcq commented May 1, 2020 •
edited
Loading

Connects #14038

Description

Updated copy used for label on LIT_SUPPORT_PULAC_CERULLO task action

Acceptance Criteria

  • Code compiles correctly
  • Task label has been updated
  • Modal route has been updated (purely visual change)

@codeclimate
Copy link

codeclimate bot commented May 1, 2020 •
edited
Loading

Code Climate has analyzed commit 64c9cd9 and detected 0 issues on this pull request.

View more on Code Climate.

Updated the url used for the Notify Lit Support modal
64c9cd9 
(removes mention of Pulac Cerullo in URL)
@jcq
Copy link
Contributor Author

jcq commented May 1, 2020

Updated Screenshot

Screen Shot 2020-05-01 at 15 50 24

leikkisa
leikkisa approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@leikkisa leikkisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to comment on the modal copy but I realized it's another ticket. This looks good to me!

@jcq jcq added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label May 2, 2020
@va-bot va-bot merged commit 7f1754a into master May 2, 2020
@va-bot va-bot deleted the jc/14038-update-pulac-cerullo-action branch May 2, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leikkisa leikkisa leikkisa approved these changes

Assignees
No one assigned
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Foxtrot 🦊
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcq @leikkisa @va-bot