-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guest link and update format of virtual hearings link #14118
Conversation
Generated by 🚫 Danger |
Code Climate has analyzed commit a373e8b and detected 0 issues on this pull request. View more on Code Climate. |
…partment-of-veterans-affairs/caseflow into shalliburton/13936-guest-link
…fairs/caseflow into shalliburton/13936-guest-link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣 Looks great to me!
Not approved, because the changes in #14099 broke the new functionality; virtual_hearings/hearing_details_spec.rb
feature tests are failing in Circle and locally. Specifically, alias
is no longer serialized with the virtual hearing, it's now alias_with_host
with different content. Update to fix and I think this'll be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! I think it'll be good to go once the change for polling is made
Resolves #13936
Description
Updated Hearing Details UI based on figma diagram: https://www.figma.com/file/V87TZArfdurCGJiEjQ73ES/Virtual-Hearings?node-id=425%3A15036
Acceptance Criteria
Testing Plan
User Facing Changes