Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guest link and update format of virtual hearings link #14118

Merged
merged 26 commits into from
May 1, 2020

Conversation

sahalliburton
Copy link
Contributor

@sahalliburton sahalliburton commented Apr 28, 2020

Resolves #13936

Description

Updated Hearing Details UI based on figma diagram: https://www.figma.com/file/V87TZArfdurCGJiEjQ73ES/Virtual-Hearings?node-id=425%3A15036

Acceptance Criteria

  • Code compiles correctly
  • User sees "Scheduling in progress" when conference is being created and emails generated
  • User sees virtual hearing details and a button to copy both guest and host link when the virtual hearing has been scheduled
  • User sees expired when the virtual hearing is past or if it is cancelled

Testing Plan

  1. Select judge "BVAYELLOW": http://localhost:3000/test/users
  2. Navigate to hearings: http://localhost:3000/hearings/schedule
  3. Choose a "Video" hearing
  4. Click the "Edit hearing details" link
  5. Ensure you do not see any virtual hearing details
  6. Change from a "Video" hearing to a "Virtual" hearing and ensure you see the "Scheduling in progress" label
  7. Once the virtual hearing has been scheduled, confirm that you see details for both the host and guest based on the Figma diagram above.
  8. Change the hearing back to "Video" and ensure that you see the expired status based on the Figma diagram

User Facing Changes

BEFORE AFTER
Previous Virtual Hearing
BeforeHearingLinkPrevious AfterHearingLinkPrevious
Virtual Hearing in progress
BeforeHearingLinkInProgress AfterHearingLinkInProgress
Virtual Hearing Active
BeforeHearingLinkActive AfterHearingLinkActive

@va-bot
Copy link
Collaborator

va-bot commented Apr 28, 2020

1 Warning
⚠️ This is a Big PR. Try to break this down if possible. Stacked pull requests encourage more detailed and thorough code reviews

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Apr 28, 2020

Code Climate has analyzed commit a373e8b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@tomas-nava tomas-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣 Looks great to me!

Not approved, because the changes in #14099 broke the new functionality; virtual_hearings/hearing_details_spec.rb feature tests are failing in Circle and locally. Specifically, alias is no longer serialized with the virtual hearing, it's now alias_with_host with different content. Update to fix and I think this'll be good to go!

Copy link

@rubaiyat22 rubaiyat22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I think it'll be good to go once the change for polling is made

@sahalliburton sahalliburton self-assigned this Apr 30, 2020
@sahalliburton sahalliburton added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Apr 30, 2020
@va-bot va-bot merged commit c3ba065 into master May 1, 2020
@va-bot va-bot deleted the shalliburton/13936-guest-link branch May 1, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master Team: Tango 💃
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display virtual hearing guest link to Hearing Coordinators
4 participants