Allow SCM Team members to perform actions on tasks for judges #13726

ajspotts · 2020-03-17T17:43:52Z

Resolves #12424

Description

This PR addresses all of the AC from #12424 except for Request Cases on behalf of the Judge which is addressed by #13727. Allows SCM users to perform all assigning and reassigning judges can.

Acceptance Criteria

Reassign ama case at judge assign to another judge by acting on a JudgeAssignTask assigned to a judge
Assign ama tasks to an attorney by acting on a JudgeAssignTask assigned to a judge
Reassign ama tasks to an attorney by acting on an AttorneyTask assigned to an attorney
Cancel an ama AttorneyTask to send it back to the judge
Reassign ama case at judge review to another judge by acting on a JudgeDecisionReviewTask assigned to a judge
Assign legacy tasks to an attorney by acting on a JudgeLegacyAssignTask assigned to a judge
Reassign legacy case at judge assign to another judge by acting on a JudgeLegacyAssignTask assigned to a judge

Testing Plan

AMA at judge assign

Sign in as BVARDUNKLE and go to /queue/3/assign (BVAAAAABSHIRE's assign queue)
Pick an AMA assign task and go to the case details screen
Check the starting task tree

Appeal.find_by(uuid: "52eaece1-0f6a-403a-844d-8882f7adfe3b").treee
                                         ┌────────────────────────────────────────────────────────────────────┐
Appeal 338 (evidence_submission) ─────── │ ID   │ STATUS    │ ASGN_BY │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                             │ 1581 │ on_hold   │         │ Bva         │ 2020-03-17 20:50:11 UTC │
    ├── DistributionTask                 │ 1582 │ completed │         │ Bva         │ 2020-03-17 20:50:53 UTC │
    │   └── EvidenceSubmissionWindowTask │ 1583 │ assigned  │         │ MailTeam    │ 2020-03-17 20:50:11 UTC │
    └── JudgeAssignTask                  │ 1584 │ assigned  │         │ BVAAABSHIRE │ 2020-03-17 20:50:53 UTC │
                                         └────────────────────────────────────────────────────────────────────┘

Select "Re-assign to a judge" and reassign to "JudgeHasAttorneys_Cases"
Task tree shows cancelled original assign task, new task is assigned to BVARERDMAN and assigned by BVARDUNKLE

                                         ┌───────────────────────────────────────────────────────────────────────┐
Appeal 338 (evidence_submission) ─────── │ ID   │ STATUS    │ ASGN_BY    │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                             │ 1581 │ on_hold   │            │ Bva         │ 2020-03-17 20:50:11 UTC │
    ├── DistributionTask                 │ 1582 │ completed │            │ Bva         │ 2020-03-17 20:50:53 UTC │
    │   └── EvidenceSubmissionWindowTask │ 1583 │ assigned  │            │ MailTeam    │ 2020-03-17 20:50:11 UTC │
    ├── JudgeAssignTask                  │ 1584 │ cancelled │            │ BVAAABSHIRE │ 2020-03-23 16:03:58 UTC │
    └── JudgeAssignTask                  │ 1604 │ assigned  │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:03:58 UTC │
                                         └───────────────────────────────────────────────────────────────────────┘

Go back to the case details of this case, assigned to and assigned by are updated
Select "Assign to attorney" and assign to "Steve Casper"
Task tree shows complete Assign task, new decision review task is assigned to BVARERDMAN, assigned by BVARDUNKLE, and a new attorney task assigned to BVASCASPER1, assigned by BVARDUNKLE

                                         ┌───────────────────────────────────────────────────────────────────────┐
Appeal 338 (evidence_submission) ─────── │ ID   │ STATUS    │ ASGN_BY    │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                             │ 1581 │ on_hold   │            │ Bva         │ 2020-03-17 20:50:11 UTC │
    ├── DistributionTask                 │ 1582 │ completed │            │ Bva         │ 2020-03-17 20:50:53 UTC │
    │   └── EvidenceSubmissionWindowTask │ 1583 │ assigned  │            │ MailTeam    │ 2020-03-17 20:50:11 UTC │
    ├── JudgeAssignTask                  │ 1584 │ cancelled │            │ BVAAABSHIRE │ 2020-03-23 16:03:58 UTC │
    ├── JudgeAssignTask                  │ 1604 │ completed │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:07:14 UTC │
    └── JudgeDecisionReviewTask          │ 1605 │ on_hold   │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:07:15 UTC │
        └── AttorneyTask                 │ 1606 │ assigned  │ BVARDUNKLE │ BVASCASPER1 │ 2020-03-23 16:07:15 UTC │
                                         └───────────────────────────────────────────────────────────────────────┘

Go back to the case details of this case, assigned to and assigned by are updated
Select "Assign to attorney" and assign to "Lexi Brown"
Task tree shows the updated assignee of BVALBROWN

                                         ┌───────────────────────────────────────────────────────────────────────┐
Appeal 338 (evidence_submission) ─────── │ ID   │ STATUS    │ ASGN_BY    │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                             │ 1581 │ on_hold   │            │ Bva         │ 2020-03-17 20:50:11 UTC │
    ├── DistributionTask                 │ 1582 │ completed │            │ Bva         │ 2020-03-17 20:50:53 UTC │
    │   └── EvidenceSubmissionWindowTask │ 1583 │ assigned  │            │ MailTeam    │ 2020-03-17 20:50:11 UTC │
    ├── JudgeAssignTask                  │ 1584 │ cancelled │            │ BVAAABSHIRE │ 2020-03-23 16:03:58 UTC │
    ├── JudgeAssignTask                  │ 1604 │ completed │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:07:14 UTC │
    └── JudgeDecisionReviewTask          │ 1605 │ on_hold   │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:07:15 UTC │
        └── AttorneyTask                 │ 1606 │ assigned  │ BVARDUNKLE │ BVALBROWN   │ 2020-03-23 16:09:47 UTC │
                                         └───────────────────────────────────────────────────────────────────────┘

Go back to the case details of this case, assigned to is updated
Select "Cancel task"
Task tree shows cancelled attorney and judge decision review task, new. judge assign task assigned to BVAAABSHIRE

                                         ┌───────────────────────────────────────────────────────────────────────┐
Appeal 338 (evidence_submission) ─────── │ ID   │ STATUS    │ ASGN_BY    │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                             │ 1581 │ on_hold   │            │ Bva         │ 2020-03-17 20:50:11 UTC │
    ├── DistributionTask                 │ 1582 │ completed │            │ Bva         │ 2020-03-17 20:50:53 UTC │
    │   └── EvidenceSubmissionWindowTask │ 1583 │ assigned  │            │ MailTeam    │ 2020-03-17 20:50:11 UTC │
    ├── JudgeAssignTask                  │ 1584 │ cancelled │            │ BVAAABSHIRE │ 2020-03-23 16:03:58 UTC │
    ├── JudgeAssignTask                  │ 1604 │ completed │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:07:14 UTC │
    ├── JudgeDecisionReviewTask          │ 1605 │ cancelled │ BVARDUNKLE │ BVARERDMAN  │ 2020-03-23 16:12:20 UTC │
    │   └── AttorneyTask                 │ 1606 │ cancelled │ BVARDUNKLE │ BVALBROWN   │ 2020-03-23 16:12:20 UTC │
    └── JudgeAssignTask                  │ 1614 │ assigned  │            │ BVAAABSHIRE │ 2020-03-23 16:15:38 UTC │
                                         └───────────────────────────────────────────────────────────────────────┘

Reassign ama case at judge assign to another judge by acting on a JudgeAssignTask assigned to a judge
Assign ama tasks to an attorney by acting on a JudgeAssignTask assigned to a judge
Reassign ama tasks to an attorney by acting on an AttorneyTask assigned to an attorney
Cancel an ama AttorneyTask to send it back to the judge

AMA at judge decision review

Pick a judge decision review task assigned to BVAAABSHIRE

uuid = JudgeDecisionReviewTask.open.where(assigned_to: User.find(3)).appeal.uuid
=> "92d5c3a6-32b4-4e9e-8a74-e1bfab94f17a"
Appeal.find_by(uuid: uuid).treee
                                ┌───────────────────────────────────────────────────────────────────────┐
Appeal 52 (direct_review) ───── │ ID  │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                    │ 585 │ on_hold   │             │ Bva         │ 2020-03-05 17:16:52 UTC │
    └── JudgeDecisionReviewTask │ 586 │ assigned  │ CSS_ID103   │ BVAAABSHIRE │ 2020-03-05 17:16:52 UTC │
        └── AttorneyTask        │ 587 │ completed │ BVAAABSHIRE │ BVASCASPER1 │ 2020-03-05 17:16:52 UTC │
                                └───────────────────────────────────────────────────────────────────────┘

Go to the case details page for this case (/queue/appeals/92d5c3a6-32b4-4e9e-8a74-e1bfab94f17a)
Select "Re-assign to a judge" and reassign to "JudgeHasAttorneys_Cases"
Task tree shows cancelled original assigne task, new task is assigned to BVARERDMAN and assigned by BVARDUNKLE, keeps the completed attorney child task

                                ┌────────────────────────────────────────────────────────────────────────┐
Appeal 52 (direct_review) ───── │ ID   │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                    │ 585  │ on_hold   │             │ Bva         │ 2020-03-05 17:16:52 UTC │
    ├── JudgeDecisionReviewTask │ 586  │ cancelled │ CSS_ID103   │ BVAAABSHIRE │ 2020-03-23 16:22:57 UTC │
    └── JudgeDecisionReviewTask │ 1615 │ assigned  │ BVARDUNKLE  │ BVARERDMAN  │ 2020-03-23 16:22:57 UTC │
        └── AttorneyTask        │ 587  │ completed │ BVAAABSHIRE │ BVASCASPER1 │ 2020-03-23 16:22:57 UTC │
                                └────────────────────────────────────────────────────────────────────────┘

Go back to the case details of this case, assigned to and assigned by are updated

Reassign ama case at judge review to another judge by acting on a JudgeDecisionReviewTask assigned to a judge

codeclimate · 2020-03-17T17:48:08Z

Code Climate has analyzed commit 01fb1f6 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

Co-authored-by: Alexander <[email protected]>

hschallhorn · 2020-03-19T20:54:36Z

app/models/tasks/judge_decision_review_task.rb

-  def additional_available_actions(_user)
+  def additional_available_actions(user)
+    return [] unless assigned_to == user
+


Ensures we're only returning judge review actions to the assignee

hschallhorn · 2020-03-19T20:56:13Z

app/models/tasks/judge_task.rb

+      [
+        Constants.TASK_ACTIONS.REASSIGN_TO_JUDGE.to_h,
+        additional_available_actions(user)
+      ].flatten


Reassign ama case at judge review to another judge by acting on a JudgeDecisionReviewTask assigned to a judge

Reassign ama case at judge assign to another judge by acting on a JudgeAssignTask assigned to a judge

Assign ama tasks to an attorney by acting on a JudgeAssignTask assigned to a judge via additional_available_actions

ajspotts · 2020-03-19T20:57:03Z

app/models/legacy_tasks/judge_legacy_assign_task.rb

@@ -8,7 +8,7 @@ def available_actions(user, role)
        Constants.TASK_ACTIONS.ASSIGN_TO_ATTORNEY.to_h,
        Constants.TASK_ACTIONS.REASSIGN_TO_JUDGE.to_h
      ]
-    elsif member_of_scm?(user)
+    elsif user.can_act_on_behalf_of_judges?


hschallhorn · 2020-03-19T20:57:58Z

app/workflows/tasks_for_appeal.rb

  end

  def legacy_appeal_tasks
+    return [] unless user_is_judge_or_attorney? || user.can_act_on_behalf_of_judges?
+


General refactoring along with making sure legacy tasks show up in case details for the scm user

💸 refactoring, legacy_appeal_and_user_is_judge_or_attorney_or_scm? was just SLIGHTLY verbose

hschallhorn · 2020-03-19T20:58:50Z

spec/controllers/tasks_controller_spec.rb

+        expect(DatabaseRequestCounter.get_counter(:vacols)).to eq(13)
+      end
+    end
+


Pulled out of judge test to be reused for the SCM user

hschallhorn · 2020-03-19T21:34:37Z

app/models/tasks/attorney_task.rb

-    errors.add(:assigned_by, "has to be a judge") if assigned_by && !assigned_by.judge_in_vacols?
+    if assigned_by && (!assigned_by.judge_in_vacols? && !assigned_by.can_act_on_behalf_of_judges?)
+      errors.add(:assigned_by, "has to be a judge or special case movement team member")
+    end


Allows SCM users to be the assigner on attorney tasks as well

hschallhorn · 2020-03-19T21:35:22Z

spec/controllers/judge_assign_tasks_controller_spec.rb

+          expect(attorney_tasks.count).to eq 3
+          attorney_tasks.each do |attorney_task|
+            expect(attorney_task["attributes"]["assigned_to"]["id"]).to eq attorney.id
+            expect(attorney_task["attributes"]["assigned_by"]["pg_id"]).to eq user.id


Ensures the assigner on the attorney task is the logged in user (scm user in our case)

hschallhorn · 2020-03-19T21:38:01Z

spec/controllers/judge_assign_tasks_controller_spec.rb

+          expect(review_tasks.count).to eq 3
+          review_tasks.each do |review_task|
+            judge_review_task = JudgeDecisionReviewTask.find(review_task["id"])
+            expect(review_task["attributes"]["assigned_to"]["id"]).to eq judge.id


Ensures the newly created judge decision review task is still assigned to the judge, regardless of who assigned it

hschallhorn · 2020-03-19T21:42:06Z

spec/controllers/tasks_controller_spec.rb

-        end
-      end
-    end
-


Removed as all attorney tasks are created through the judge assign tasks controller

hschallhorn · 2020-03-23T15:42:08Z

app/repositories/task_action_repository.rb

      {
        selected: nil,
-        options: nil,
+        options: user.can_act_on_behalf_of_judges? ? users_to_options(Attorney.list_all) : nil,


Ensures SCM users can view attorney assignees

hschallhorn · 2020-03-24T15:54:59Z

Closing to break out into separate PRs!

ajspotts added 4 commits March 5, 2020 14:33

scm can reassign ama case at judge assign & review

ff339fa

scm can reassign legacy case at judge assign

d73c4bc

refactor to elsif/else, abstract private methods

0d157ca

abstract member_of_scm? method

8fdc33d

lomky and others added 3 commits March 17, 2020 16:54

Available action test for SCM user on judge task

e01b203

Co-authored-by: Alexander <[email protected]>

code climate fixes

3b74e82

Merge branch 'master' into alec/12424-scm-perform-judge-actions

4f84263

hschallhorn self-assigned this Mar 19, 2020

hschallhorn added 4 commits March 19, 2020 16:41

Removed unused function

756d8b4

Use new user function and only return actions to assignee of jdrtask

4dc6cde

Unit and controller testing!

5893e08

Code climate

8ae792d

hschallhorn changed the title ~~Alec/12424 scm perform judge actions~~ Allow SCM Team members to perform actions on tasks for judges Mar 19, 2020

hschallhorn reviewed Mar 19, 2020

View reviewed changes

ajspotts commented Mar 19, 2020

View reviewed changes

hschallhorn reviewed Mar 19, 2020

View reviewed changes

hschallhorn added 2 commits March 19, 2020 16:59

Words words words

339461a

Allow scm users to create attorney tasks and test it!

8a69f2b

hschallhorn reviewed Mar 19, 2020

View reviewed changes

hschallhorn added 4 commits March 20, 2020 12:00

Rename class to match file

0a2e82a

Make sure the judge can see who assigned this to them as well

2733e46

Ensure list of attorneys show up in assign widget for scm user

41aebd2

Allow SCM users to cancel and reassign atty tasks as well

97a7731

hschallhorn mentioned this pull request Mar 23, 2020

CM: Allow SCM Team members to perform actions for judges #12424

Closed

8 tasks

hschallhorn and others added 3 commits March 23, 2020 11:04

Linting and cc

31b2841

Merge branch 'master' into alec/12424-scm-perform-judge-actions

01fb1f6

Wording

23674bc

hschallhorn reviewed Mar 23, 2020

View reviewed changes

hschallhorn and others added 3 commits March 24, 2020 11:48

Ensure judge assign task is reopened for correct judge

f501ac7

Add legacy task test

3b55399

Merge branch 'master' into alec/12424-scm-perform-judge-actions

8eafa97

hschallhorn closed this Mar 24, 2020

hschallhorn deleted the alec/12424-scm-perform-judge-actions branch April 22, 2020 02:21

hschallhorn restored the alec/12424-scm-perform-judge-actions branch April 22, 2020 02:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow SCM Team members to perform actions on tasks for judges #13726

Allow SCM Team members to perform actions on tasks for judges #13726

ajspotts commented Mar 17, 2020 •

edited by hschallhorn

Loading

codeclimate bot commented Mar 17, 2020 •

edited

Loading

hschallhorn Mar 19, 2020

hschallhorn Mar 19, 2020

ajspotts Mar 19, 2020

hschallhorn Mar 19, 2020

ajspotts Mar 19, 2020

hschallhorn Mar 19, 2020

hschallhorn Mar 19, 2020 •

edited

Loading

hschallhorn Mar 19, 2020

hschallhorn Mar 19, 2020

hschallhorn Mar 19, 2020

hschallhorn Mar 23, 2020

hschallhorn commented Mar 24, 2020

Allow SCM Team members to perform actions on tasks for judges #13726

Allow SCM Team members to perform actions on tasks for judges #13726

Conversation

ajspotts commented Mar 17, 2020 • edited by hschallhorn Loading

Description

Acceptance Criteria

Testing Plan

AMA at judge assign

AMA at judge decision review

codeclimate bot commented Mar 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hschallhorn Mar 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hschallhorn commented Mar 24, 2020

ajspotts commented Mar 17, 2020 •

edited by hschallhorn

Loading

codeclimate bot commented Mar 17, 2020 •

edited

Loading

hschallhorn Mar 19, 2020 •

edited

Loading