Fix dislocated parent tasks in FactoryBot - Part 2 #13605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomlam
changed the base branch from
master
to
yoom/13130.1-factoryBot_dislocated_parent_tasks
|
Code Climate has analyzed commit b9cd9b7 and detected 0 issues on this pull request. View more on Code Climate. |
yoomlam
commented
Mar 4, 2020
spec/factories/task.rb
Outdated
| factory :change_hearing_disposition_task, class: ChangeHearingDispositionTask do | ||
| type { ChangeHearingDispositionTask.name } | ||
| assigned_to { HearingAdmin.singleton } | ||
| factory :ama_task_base_factory do |
There was a problem hiding this comment.
New parent factory to collect all AMA tasks.
Generated by 🚫 Danger |
yoomlam
commented
Mar 4, 2020
spec/factories/task.rb
Outdated
Comment on lines
239
to
248
| factory :appeal_task, class: DecisionReviewTask do | ||
| type { DecisionReviewTask.name } | ||
| appeal { create(:appeal, benefit_type: "education") } | ||
| assigned_by { nil } | ||
| end | ||
|
|
||
| factory :assign_hearing_disposition_task, class: AssignHearingDispositionTask do | ||
| type { AssignHearingDispositionTask.name } | ||
| assigned_to { Bva.singleton } | ||
| appeal | ||
| parent { create(:hearing_task) } | ||
| factory :higher_level_review_task, class: DecisionReviewTask do | ||
| type { DecisionReviewTask.name } | ||
| appeal { create(:higher_level_review, benefit_type: "education") } | ||
| assigned_by { nil } |
There was a problem hiding this comment.
Deal with these later (in a subsequent stacked PR) since they create appeals differently.
1 task
hschallhorn
reviewed
Mar 4, 2020
| appeal | ||
| end | ||
| factory :ama_colocated_task, traits: [ColocatedTask.actions_assigned_to_colocated.sample.to_sym], | ||
| parent: :colocated_task do |
There was a problem hiding this comment.
Didn't know we could call a different parent. 👌
hschallhorn
reviewed
Mar 4, 2020
spec/factories/task.rb
Outdated
| end | ||
| factory :ama_task, class: Task do | ||
| type { Task.name } | ||
| end |
There was a problem hiding this comment.
Could we use this task as the parent factory instead as it already serves as a base "generic task on an ama appeal"?
There was a problem hiding this comment.
Sure! My only concern is class: Task, i.e., if child factories will override it properly. I created a parent ama_task_base_factory in Part 3 so I'll execute your suggestion there.
yoomlam
added
Type: Tech-Improvement
Team: Echo 🐬
Priority: Low
* DRY it up by setting task.type based on declared `class` * set attributes before saving task record * use ama_task as the parent factory * Fix dislocated parent tasks in FactoryBot - Part 4 (#13607) * create parent tasks to be in the same appeal * check parent task consistency * create the task in the parent's appeal * temporarily disable the check * fix tests * address deprecation warning * add warnings * move task that create their own appeal under ama_task * remove warnings * add code comment for diagnosis if tests fail * Fix dislocated parent tasks in FactoryBot - Part 5 (#13620) * trial to see how many tests fail * test colocated_task having no parent * fix some tests with Kat * check if any tests would produce this warning * don't leave colocated_task type selection to chance * always pass appeal when creating parent task * fix extra appeal created due to overriding appeal * pass the task as the parent, not the id * pass the task as the parent, not the id * don't pass appeal if parent task is provided * pass parent task so the created task is in same appeal * pass actual parent task, not id * increase counts to account for colocated's parent * pass appeal when creating root_task * add comments; adjust failure message * reload task to see it's new children
yoomlam
added a commit
that referenced
this pull request
Mar 12, 2020
* set task's appeal consistently * move outlier away from those that fit a pattern * Fix dislocated parent tasks in FactoryBot - Part 2 (#13605) * collect ama tasks together * group all ama tasks under a common parent factory * make it DRY * Fix dislocated parent tasks in FactoryBot - Part 3 (#13606) * DRY it up by setting task.type based on declared `class` * set attributes before saving task record * use ama_task as the parent factory * Fix dislocated parent tasks in FactoryBot - Part 4 (#13607) * create parent tasks to be in the same appeal * check parent task consistency * create the task in the parent's appeal * temporarily disable the check * fix tests * address deprecation warning * add warnings * move task that create their own appeal under ama_task * remove warnings * add code comment for diagnosis if tests fail * Fix dislocated parent tasks in FactoryBot - Part 5 (#13620) * trial to see how many tests fail * test colocated_task having no parent * fix some tests with Kat * check if any tests would produce this warning * don't leave colocated_task type selection to chance * always pass appeal when creating parent task * fix extra appeal created due to overriding appeal * pass the task as the parent, not the id * pass the task as the parent, not the id * don't pass appeal if parent task is provided * pass parent task so the created task is in same appeal * pass actual parent task, not id * increase counts to account for colocated's parent * pass appeal when creating root_task * add comments; adjust failure message * reload task to see it's new children * address CodeClimate complaints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #13130
Part 1 #13604
Description
Second, collect and group all AMA tasks together under a common parent factory, in preparation for next part.
Acceptance Criteria