Set Up Container Component for MTV Checkout Workflows #13334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 3, 2020 13:22
created motionToVacateRoutes & incorporated into QueueApp;
created MotionToVacateContext & provider;
|
Code Climate has analyzed commit beced6a and detected 0 issues on this pull request. View more on Code Climate. |
added 3 commits
February 3, 2020 16:32
(needed to use default export); commented out now-unused MTV-related items from QueueApp;
leikkisa
reviewed
Feb 5, 2020
There was a problem hiding this comment.
I'd prefer some of the stuff that is getting taken out to be removed altogether instead of commented out, for being merged into master. This is so WIP-y (although TBH the feature itself is still a WIP!).
I am also still feeling a little bit iffy about the extra piece of the URL, I might need you to explain more about how it's being used.
a couple of updates to avoid linting warnings;
leikkisa
approved these changes
Feb 6, 2020
| @@ -461,6 +434,8 @@ class QueueApp extends React.PureComponent { | |||
| title="User Management | Caseflow" | |||
| render={this.routedUserManagement} | |||
| /> | |||
|
|
|||
| {motionToVacateRoutes.page} | |||
There was a problem hiding this comment.
This is very pretty and nicely done!
| @@ -657,6 +618,8 @@ class QueueApp extends React.PureComponent { | |||
| <Route path="/team_management/add_vso" render={this.routedAddVsoModal} /> | |||
| <Route path="/team_management/add_private_bar" render={this.routedAddPrivateBarModal} /> | |||
| <Route path="/team_management/lookup_participant_id" render={this.routedLookupParticipantIdModal} /> | |||
|
|
|||
| {motionToVacateRoutes.modal} | |||
jcq
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #13318
Description
This does multiple things:
QueueAppto break out MTV routes into their own fileAcceptance Criteria