Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message for RedistributedCase Sentry alert #12803

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Update message for RedistributedCase Sentry alert #12803

merged 4 commits into from
Nov 27, 2019

Conversation

alisan16
Copy link
Contributor

Make error message for RedistributedCase::CannotRedistribute error generic so Sentry can better group the similar errors together. With the change in #12190, the error was made specific with a Case ID #, breaking the grouping logic in Sentry and resulting in new issues for each case:

Screen Shot 2019-11-25 at 2 50 32 PM

@codeclimate
Copy link

codeclimate bot commented Nov 25, 2019

Code Climate has analyzed commit 32b4be0 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@pkarman pkarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alisan16 alisan16 merged commit 38298e5 into master Nov 27, 2019
@alisan16 alisan16 deleted the case0 branch November 27, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants