Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement naive caching for queue pagination API #12131

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

lowellrex
Copy link
Contributor

Connects #11310. Adds naive caching based only on the URL of the endpoint we are making the task page request to. Later on, we can add the ability to bypass the API request when there is only a single page of results (thus the front-end already has access to all of the rows that the back-end could possibly return so we can do all of the filtering on the front-end without needing to involve the back-end).

In the screen capture below, notice that the second time we make a request for hearing clarification tasks we do not make an API request.

naive_caching

@lowellrex lowellrex self-assigned this Sep 17, 2019
@codeclimate
Copy link

codeclimate bot commented Sep 17, 2019

Code Climate has analyzed commit bc6caaa and detected 0 issues on this pull request.

View more on Code Climate.

@hschallhorn
Copy link
Contributor

I think we should cache the tasks from viewing the default view (page 1, no filters, no sort) as well, so we don't get the request after clearing the filters in the screen grab

Copy link
Contributor

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second the desire to cache our initial empty params tasks too, but happy for that to be in this PR or a follow on!

@lowellrex
Copy link
Contributor Author

I second the desire to cache our initial empty params tasks too, but happy for that to be in this PR or a follow on!

Will cache initial set of tasks in another PR.

@lowellrex lowellrex added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Sep 17, 2019
@va-bot va-bot merged commit f14f09b into master Sep 17, 2019
@va-bot va-bot deleted the lowell/11310_naive_caching branch September 17, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants