progress pr - Batch requests in task table #10382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Code Climate has analyzed commit 94b8d14f and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
anyakhvost
reviewed
Apr 11, 2019
…fairs/caseflow into Batch-Requests-In-Task-Table
…artment-of-veterans-affairs/caseflow into Batch-Requests-In-Task-Table
youngfreezyVA
commented
Apr 11, 2019
| render(error.serialize_response) | ||
| end | ||
|
|
||
| def build_document_counts_hash |
There was a problem hiding this comment.
@monfresh do you have any thoughts on how to get code climate to not complain about this having 7 statements?
youngfreezyVA
commented
Apr 11, 2019
| render json: { most_recently_held_hearings_by_id: build_most_recently_held_hearings_hash } | ||
| end | ||
|
|
||
| def build_most_recently_held_hearings_hash |
There was a problem hiding this comment.
@monfresh same here
There was a problem hiding this comment.
there's going to be alot of changes to this, so please hold off for now i'll reach back out when its ready if i'm still facing this issue, thank you!
youngfreezyVA
force-pushed
the
Batch-Requests-In-Task-Table
branch
from
94b8d14
to
c39ab29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8934