Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save issue withdrawals #10381

Merged
merged 8 commits into from
Apr 10, 2019
Merged

Save issue withdrawals #10381

merged 8 commits into from
Apr 10, 2019

Conversation

leikkisa
Copy link
Contributor

connects #9985

@ghost ghost assigned leikkisa Apr 10, 2019
@ghost ghost added the In-Progress label Apr 10, 2019
@va-bot
Copy link
Collaborator

va-bot commented Apr 10, 2019

1 Warning
⚠️ This PR changes the schema. Please use the PR template checklist.

Generated by 🚫 Danger

@codeclimate
Copy link

codeclimate bot commented Apr 10, 2019 •
edited
Loading

Code Climate has analyzed commit c4293e0 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4

View more on Code Climate.

@leikkisa leikkisa changed the title Withdraw save working Save issue withdrawals Apr 10, 2019
Sjones352
Sjones352 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@Sjones352 Sjones352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Save is working

@leikkisa leikkisa added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Apr 10, 2019
@ghost ghost assigned va-bot Apr 10, 2019
@leikkisa leikkisa merged commit b2d08c3 into master Apr 10, 2019
@ghost ghost removed the In-Progress label Apr 10, 2019
@leikkisa leikkisa deleted the 9985-save-withdrawn-issues branch April 10, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sjones352 Sjones352 Sjones352 approved these changes

@pkarman pkarman Awaiting requested review from pkarman

Assignees

@leikkisa leikkisa

@va-bot va-bot

Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leikkisa @va-bot @Sjones352