Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create change disposition task, actions, and modal #10313

Merged

Conversation

tomas-nava
Copy link
Contributor

@tomas-nava tomas-nava commented Apr 4, 2019

Connects #9885
Connects #9833

Description

Creates a ChangeHearingDispositionTask and associated modal. Includes small changes to disposition task logic to support postponing hearings from this task. The backend logic for other hearing dispositions are not yet implemented.

@ghost ghost assigned tomas-nava Apr 4, 2019
@ghost ghost added the In-Progress label Apr 4, 2019
@codeclimate
Copy link

codeclimate bot commented Apr 4, 2019

Code Climate has analyzed commit 465a971 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 1

View more on Code Climate.

Copy link
Contributor

@sharonwarner sharonwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!!

One small thing - do you mind changing resolves to connects in the PR description? I don't want the ticket to get closed and to lose track of it!

tomas-nava and others added 4 commits April 4, 2019 14:29
made a lot of disposition task's methods private and removed an
unneeded include from the change hearing disposition modal
@va-bot
Copy link
Collaborator

va-bot commented Apr 4, 2019

1 Warning
⚠️ This is a Big PR. Try to break this down if possible.

Generated by 🚫 Danger

@tomas-nava tomas-nava added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Apr 8, 2019
@ghost ghost assigned va-bot Apr 8, 2019
@tomas-nava tomas-nava merged commit 4cc82a2 into master Apr 8, 2019
@ghost ghost removed the In-Progress label Apr 8, 2019
@tomas-nava tomas-nava deleted the queue/tomas/9885-create-change-disposition-task-and-actions branch April 8, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants