-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically restart timed tasks with delay in the past #10028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanear
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird bug. Thanks for fixing!
pkarman
added
the
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
label
Mar 18, 2019
amprokop
reviewed
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
va-bot
pushed a commit
that referenced
this pull request
Aug 20, 2019
Bumps [eslint](https://github.com/eslint/eslint) from 4.9.0 to 4.18.2. <details> <summary>Release notes</summary> *Sourced from [eslint's releases](https://github.com/eslint/eslint/releases).* > ## v4.18.2 > * 6b71fd0 Fix: [email protected], because 4.0.3 needs "ajv": "^6.0.1" ([#10022](https://github-redirect.dependabot.com/eslint/eslint/issues/10022)) (Mathieu Seiler) > * 3c697de Chore: fix incorrect comment about linter.verify return value ([#10030](https://github-redirect.dependabot.com/eslint/eslint/issues/10030)) (Teddy Katz) > * 9df8653 Chore: refactor parser-loading out of linter.verify ([#10028](https://github-redirect.dependabot.com/eslint/eslint/issues/10028)) (Teddy Katz) > * f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes [#10002](https://github-redirect.dependabot.com/eslint/eslint/issues/10002)) ([#10019](https://github-redirect.dependabot.com/eslint/eslint/issues/10019)) (Jamie Davis) > * e4f52ce Chore: Simplify dataflow in linter.verify ([#10020](https://github-redirect.dependabot.com/eslint/eslint/issues/10020)) (Teddy Katz) > * 33177cd Chore: make library files non-executable ([#10021](https://github-redirect.dependabot.com/eslint/eslint/issues/10021)) (Teddy Katz) > * 558ccba Chore: refactor directive comment processing ([#10007](https://github-redirect.dependabot.com/eslint/eslint/issues/10007)) (Teddy Katz) > * 18e15d9 Chore: avoid useless catch clauses that just rethrow errors ([#10010](https://github-redirect.dependabot.com/eslint/eslint/issues/10010)) (Teddy Katz) > * a1c3759 Chore: refactor populating configs with defaults in linter ([#10006](https://github-redirect.dependabot.com/eslint/eslint/issues/10006)) (Teddy Katz) > * aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes [#9954](https://github-redirect.dependabot.com/eslint/eslint/issues/9954)) ([#9985](https://github-redirect.dependabot.com/eslint/eslint/issues/9985)) (Rachael Sim) > > ## v4.18.1 > * f417506 Fix: ensure no-await-in-loop reports the correct node (fixes [#9992](https://github-redirect.dependabot.com/eslint/eslint/issues/9992)) ([#9993](https://github-redirect.dependabot.com/eslint/eslint/issues/9993)) (Teddy Katz) > * 3e99363 Docs: Fixed typo in key-spacing rule doc ([#9987](https://github-redirect.dependabot.com/eslint/eslint/issues/9987)) (Jaid) > * 7c2cd70 Docs: deprecate experimentalObjectRestSpread ([#9986](https://github-redirect.dependabot.com/eslint/eslint/issues/9986)) (Toru Nagashima) > > ## v4.18.0 > * 70f22f3 Chore: Apply memoization to config creation within glob utils ([#9944](https://github-redirect.dependabot.com/eslint/eslint/issues/9944)) (Kenton Jacobsen) > * 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes [#9882](https://github-redirect.dependabot.com/eslint/eslint/issues/9882)) ([#9951](https://github-redirect.dependabot.com/eslint/eslint/issues/9951)) (Teddy Katz) > * 47ac478 Update: add named imports and exports for object-curly-newline ([#9876](https://github-redirect.dependabot.com/eslint/eslint/issues/9876)) (Nicholas Chua) > * e8efdd0 Fix: support Rest/Spread Properties (fixes [#9885](https://github-redirect.dependabot.com/eslint/eslint/issues/9885)) ([#9943](https://github-redirect.dependabot.com/eslint/eslint/issues/9943)) (Toru Nagashima) > * f012b8c Fix: support Async iteration (fixes [#9891](https://github-redirect.dependabot.com/eslint/eslint/issues/9891)) ([#9957](https://github-redirect.dependabot.com/eslint/eslint/issues/9957)) (Toru Nagashima) > * 74fa253 Docs: Clarify no-mixed-operators options (fixes [#9962](https://github-redirect.dependabot.com/eslint/eslint/issues/9962)) ([#9964](https://github-redirect.dependabot.com/eslint/eslint/issues/9964)) (Ivan Hayes) > * 426868f Docs: clean up key-spacing docs (fixes [#9900](https://github-redirect.dependabot.com/eslint/eslint/issues/9900)) ([#9963](https://github-redirect.dependabot.com/eslint/eslint/issues/9963)) (Abid Uzair) > * 4a6f22e Update: support eslint-disable-* block comments (fixes [#8781](https://github-redirect.dependabot.com/eslint/eslint/issues/8781)) ([#9745](https://github-redirect.dependabot.com/eslint/eslint/issues/9745)) (Erin) > * 777283b Docs: Propose fix typo for function ([#9965](https://github-redirect.dependabot.com/eslint/eslint/issues/9965)) (John Eismeier) > * bf3d494 Docs: Fix typo in max-len ignorePattern example. ([#9956](https://github-redirect.dependabot.com/eslint/eslint/issues/9956)) (Tim Martin) > * d64fbb4 Docs: fix typo in prefer-destructuring.md example ([#9930](https://github-redirect.dependabot.com/eslint/eslint/issues/9930)) (Vse Mozhet Byt) > * f8d343f Chore: Fix default issue template ([#9946](https://github-redirect.dependabot.com/eslint/eslint/issues/9946)) (Kai Cataldo) > > ## v4.17.0 > * 1da1ada Update: Add "multiline" type to padding-line-between-statements ([#8668](https://github-redirect.dependabot.com/eslint/eslint/issues/8668)) (Matthew Bennett) > * bb213dc Chore: Use messageIds in some of the core rules ([#9648](https://github-redirect.dependabot.com/eslint/eslint/issues/9648)) (Jed Fox) > * 1aa1970 Docs: remove outdated rule naming convention ([#9925](https://github-redirect.dependabot.com/eslint/eslint/issues/9925)) (Teddy Katz) > * 3afaff6 Docs: Add prefer-destructuring variable reassignment example ([#9873](https://github-redirect.dependabot.com/eslint/eslint/issues/9873)) (LePirlouit) > * d20f6b4 Fix: Typo in error message when running npm ([#9866](https://github-redirect.dependabot.com/eslint/eslint/issues/9866)) (Maciej Kasprzyk) > * 51ec6a7 Docs: Use GitHub Multiple PR/Issue templates ([#9911](https://github-redirect.dependabot.com/eslint/eslint/issues/9911)) (Kai Cataldo) > * dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes [#9907](https://github-redirect.dependabot.com/eslint/eslint/issues/9907)) ([#9906](https://github-redirect.dependabot.com/eslint/eslint/issues/9906)) (Kevin Partington) > * 084351b Docs: Fix the messageId example (fixes [#9889](https://github-redirect.dependabot.com/eslint/eslint/issues/9889)) ([#9892](https://github-redirect.dependabot.com/eslint/eslint/issues/9892)) (Jed Fox) > * 9cbb487 Docs: Mention the `globals` key in the no-undef docs ([#9867](https://github-redirect.dependabot.com/eslint/eslint/issues/9867)) (Dan Dascalescu) > > ## v4.16.0 > * e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes [#7567](https://github-redirect.dependabot.com/eslint/eslint/issues/7567)) ([#9796](https://github-redirect.dependabot.com/eslint/eslint/issues/9796)) (Michael Ficarra) > * af043eb Update: Add NewExpression support to comma-style ([#9591](https://github-redirect.dependabot.com/eslint/eslint/issues/9591)) (Frazer McLean) > * 4f898c7 Build: Fix JSDoc syntax errors ([#9813](https://github-redirect.dependabot.com/eslint/eslint/issues/9813)) (Matija Marohnić) > * 13bcf3c Fix: Removing curly quotes in no-eq-null report message ([#9852](https://github-redirect.dependabot.com/eslint/eslint/issues/9852)) (Kevin Partington) > * b96fb31 Docs: configuration hierarchy for CLIEngine options (fixes [#9526](https://github-redirect.dependabot.com/eslint/eslint/issues/9526)) ([#9855](https://github-redirect.dependabot.com/eslint/eslint/issues/9855)) (PiIsFour) > * 8ccbdda Docs: Clarify that -c configs merge with `.eslintrc.*` (fixes [#9535](https://github-redirect.dependabot.com/eslint/eslint/issues/9535)) ([#9847](https://github-redirect.dependabot.com/eslint/eslint/issues/9847)) (Kevin Partington) > * 978574f Docs: Fix examples for no-useless-escape ([#9853](https://github-redirect.dependabot.com/eslint/eslint/issues/9853)) (Toru Kobayashi) ></tr></table> ... (truncated) </details> <details> <summary>Changelog</summary> *Sourced from [eslint's changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md).* > v4.18.2 - March 2, 2018 > > * 6b71fd0 Fix: [email protected], because 4.0.3 needs "ajv": "^6.0.1" ([#10022](https://github-redirect.dependabot.com/eslint/eslint/issues/10022)) (Mathieu Seiler) > * 3c697de Chore: fix incorrect comment about linter.verify return value ([#10030](https://github-redirect.dependabot.com/eslint/eslint/issues/10030)) (Teddy Katz) > * 9df8653 Chore: refactor parser-loading out of linter.verify ([#10028](https://github-redirect.dependabot.com/eslint/eslint/issues/10028)) (Teddy Katz) > * f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes [#10002](https://github-redirect.dependabot.com/eslint/eslint/issues/10002)) ([#10019](https://github-redirect.dependabot.com/eslint/eslint/issues/10019)) (Jamie Davis) > * e4f52ce Chore: Simplify dataflow in linter.verify ([#10020](https://github-redirect.dependabot.com/eslint/eslint/issues/10020)) (Teddy Katz) > * 33177cd Chore: make library files non-executable ([#10021](https://github-redirect.dependabot.com/eslint/eslint/issues/10021)) (Teddy Katz) > * 558ccba Chore: refactor directive comment processing ([#10007](https://github-redirect.dependabot.com/eslint/eslint/issues/10007)) (Teddy Katz) > * 18e15d9 Chore: avoid useless catch clauses that just rethrow errors ([#10010](https://github-redirect.dependabot.com/eslint/eslint/issues/10010)) (Teddy Katz) > * a1c3759 Chore: refactor populating configs with defaults in linter ([#10006](https://github-redirect.dependabot.com/eslint/eslint/issues/10006)) (Teddy Katz) > * aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes [#9954](https://github-redirect.dependabot.com/eslint/eslint/issues/9954)) ([#9985](https://github-redirect.dependabot.com/eslint/eslint/issues/9985)) (Rachael Sim) > > v4.18.1 - February 20, 2018 > > * f417506 Fix: ensure no-await-in-loop reports the correct node (fixes [#9992](https://github-redirect.dependabot.com/eslint/eslint/issues/9992)) ([#9993](https://github-redirect.dependabot.com/eslint/eslint/issues/9993)) (Teddy Katz) > * 3e99363 Docs: Fixed typo in key-spacing rule doc ([#9987](https://github-redirect.dependabot.com/eslint/eslint/issues/9987)) (Jaid) > * 7c2cd70 Docs: deprecate experimentalObjectRestSpread ([#9986](https://github-redirect.dependabot.com/eslint/eslint/issues/9986)) (Toru Nagashima) > > v4.18.0 - February 16, 2018 > > * 70f22f3 Chore: Apply memoization to config creation within glob utils ([#9944](https://github-redirect.dependabot.com/eslint/eslint/issues/9944)) (Kenton Jacobsen) > * 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes [#9882](https://github-redirect.dependabot.com/eslint/eslint/issues/9882)) ([#9951](https://github-redirect.dependabot.com/eslint/eslint/issues/9951)) (Teddy Katz) > * 47ac478 Update: add named imports and exports for object-curly-newline ([#9876](https://github-redirect.dependabot.com/eslint/eslint/issues/9876)) (Nicholas Chua) > * e8efdd0 Fix: support Rest/Spread Properties (fixes [#9885](https://github-redirect.dependabot.com/eslint/eslint/issues/9885)) ([#9943](https://github-redirect.dependabot.com/eslint/eslint/issues/9943)) (Toru Nagashima) > * f012b8c Fix: support Async iteration (fixes [#9891](https://github-redirect.dependabot.com/eslint/eslint/issues/9891)) ([#9957](https://github-redirect.dependabot.com/eslint/eslint/issues/9957)) (Toru Nagashima) > * 74fa253 Docs: Clarify no-mixed-operators options (fixes [#9962](https://github-redirect.dependabot.com/eslint/eslint/issues/9962)) ([#9964](https://github-redirect.dependabot.com/eslint/eslint/issues/9964)) (Ivan Hayes) > * 426868f Docs: clean up key-spacing docs (fixes [#9900](https://github-redirect.dependabot.com/eslint/eslint/issues/9900)) ([#9963](https://github-redirect.dependabot.com/eslint/eslint/issues/9963)) (Abid Uzair) > * 4a6f22e Update: support eslint-disable-* block comments (fixes [#8781](https://github-redirect.dependabot.com/eslint/eslint/issues/8781)) ([#9745](https://github-redirect.dependabot.com/eslint/eslint/issues/9745)) (Erin) > * 777283b Docs: Propose fix typo for function ([#9965](https://github-redirect.dependabot.com/eslint/eslint/issues/9965)) (John Eismeier) > * bf3d494 Docs: Fix typo in max-len ignorePattern example. ([#9956](https://github-redirect.dependabot.com/eslint/eslint/issues/9956)) (Tim Martin) > * d64fbb4 Docs: fix typo in prefer-destructuring.md example ([#9930](https://github-redirect.dependabot.com/eslint/eslint/issues/9930)) (Vse Mozhet Byt) > * f8d343f Chore: Fix default issue template ([#9946](https://github-redirect.dependabot.com/eslint/eslint/issues/9946)) (Kai Cataldo) > > v4.17.0 - February 2, 2018 > > * 1da1ada Update: Add "multiline" type to padding-line-between-statements ([#8668](https://github-redirect.dependabot.com/eslint/eslint/issues/8668)) (Matthew Bennett) > * bb213dc Chore: Use messageIds in some of the core rules ([#9648](https://github-redirect.dependabot.com/eslint/eslint/issues/9648)) (Jed Fox) > * 1aa1970 Docs: remove outdated rule naming convention ([#9925](https://github-redirect.dependabot.com/eslint/eslint/issues/9925)) (Teddy Katz) > * 3afaff6 Docs: Add prefer-destructuring variable reassignment example ([#9873](https://github-redirect.dependabot.com/eslint/eslint/issues/9873)) (LePirlouit) > * d20f6b4 Fix: Typo in error message when running npm ([#9866](https://github-redirect.dependabot.com/eslint/eslint/issues/9866)) (Maciej Kasprzyk) > * 51ec6a7 Docs: Use GitHub Multiple PR/Issue templates ([#9911](https://github-redirect.dependabot.com/eslint/eslint/issues/9911)) (Kai Cataldo) > * dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes [#9907](https://github-redirect.dependabot.com/eslint/eslint/issues/9907)) ([#9906](https://github-redirect.dependabot.com/eslint/eslint/issues/9906)) (Kevin Partington) > * 084351b Docs: Fix the messageId example (fixes [#9889](https://github-redirect.dependabot.com/eslint/eslint/issues/9889)) ([#9892](https://github-redirect.dependabot.com/eslint/eslint/issues/9892)) (Jed Fox) > * 9cbb487 Docs: Mention the `globals` key in the no-undef docs ([#9867](https://github-redirect.dependabot.com/eslint/eslint/issues/9867)) (Dan Dascalescu) > > v4.16.0 - January 19, 2018 > > * e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes [#7567](https://github-redirect.dependabot.com/eslint/eslint/issues/7567)) ([#9796](https://github-redirect.dependabot.com/eslint/eslint/issues/9796)) (Michael Ficarra) > * af043eb Update: Add NewExpression support to comma-style ([#9591](https://github-redirect.dependabot.com/eslint/eslint/issues/9591)) (Frazer McLean) ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`22ff6f3`](eslint/eslint@22ff6f3) 4.18.2 - [`817b84b`](eslint/eslint@817b84b) Build: changelog update for 4.18.2 - [`6b71fd0`](eslint/eslint@6b71fd0) Fix: [email protected], because 4.0.3 needs "ajv": "^6.0.1" ([#10022](https://github-redirect.dependabot.com/eslint/eslint/issues/10022)) - [`3c697de`](eslint/eslint@3c697de) Chore: fix incorrect comment about linter.verify return value ([#10030](https://github-redirect.dependabot.com/eslint/eslint/issues/10030)) - [`9df8653`](eslint/eslint@9df8653) Chore: refactor parser-loading out of linter.verify ([#10028](https://github-redirect.dependabot.com/eslint/eslint/issues/10028)) - [`f6901d0`](eslint/eslint@f6901d0) Fix: remove catastrophic backtracking vulnerability (fixes [#10002](https://github-redirect.dependabot.com/eslint/eslint/issues/10002)) ([#10019](https://github-redirect.dependabot.com/eslint/eslint/issues/10019)) - [`e4f52ce`](eslint/eslint@e4f52ce) Chore: Simplify dataflow in linter.verify ([#10020](https://github-redirect.dependabot.com/eslint/eslint/issues/10020)) - [`33177cd`](eslint/eslint@33177cd) Chore: make library files non-executable ([#10021](https://github-redirect.dependabot.com/eslint/eslint/issues/10021)) - [`558ccba`](eslint/eslint@558ccba) Chore: refactor directive comment processing ([#10007](https://github-redirect.dependabot.com/eslint/eslint/issues/10007)) - [`18e15d9`](eslint/eslint@18e15d9) Chore: avoid useless catch clauses that just rethrow errors ([#10010](https://github-redirect.dependabot.com/eslint/eslint/issues/10010)) - Additional commits viewable in [compare view](eslint/eslint@v4.9.0...v4.18.2) </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=4.9.0&new-version=4.18.2)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/department-of-veterans-affairs/caseflow/network/alerts). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TaskTimer objects in production would never process because they had submitted at times in the past.